Skip to content

sessions: make changes diffs responsive - #331851

Merged
Sandeep Somavarapu (sandy081) merged 4 commits into
mainfrom
sandy081/agents/responsive-inline-side-by-side-diff
Aug 20, 2026
Merged

sessions: make changes diffs responsive#331851
Sandeep Somavarapu (sandy081) merged 4 commits into
mainfrom
sandy081/agents/responsive-inline-side-by-side-diff

Conversation

@sandy081

@sandy081 Sandeep Somavarapu (sandy081) commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • make both the Agents Window Session Changes editor and standard text diff editors prefer side-by-side while automatically falling back to inline when space is limited
  • share and persist one Agents Window diff-layout preference across both supported surfaces without changing normal workbench diff behavior or workspace configuration
  • clarify the preference action labels, tooltips, checked state, and accessibility help
  • keep every visible Agents Window text diff synchronized when the preference changes

Validation

  • npm run compile
  • npm run hygiene
  • npm run valid-layers-check
  • targeted unit tests (17 passing)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 20, 2026 18:17
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.135.0 milestone Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes Agents Window diffs responsive while preserving a Sessions-specific layout preference.

Changes:

  • Adds persisted side-by-side preference for Session Changes.
  • Enables responsive inline fallback in multi-diff and single-file editors.
  • Updates actions, accessibility help, and tests.
Show a summary per file
File Description
src/vs/sessions/contrib/editor/test/browser/diffEditor.sessions.contribution.test.ts Tests Sessions-specific toggling.
src/vs/sessions/contrib/editor/browser/diffEditor.sessions.contribution.ts Applies configured responsive layouts.
src/vs/sessions/contrib/changes/test/browser/changesViewActions.test.ts Updates action metadata tests.
src/vs/sessions/contrib/changes/browser/sessionsChangesAccessibilityHelp.ts Describes responsive preferences.
src/vs/sessions/contrib/changes/browser/sessionChangesEditor.ts Persists and applies the preferred layout.
src/vs/sessions/contrib/changes/browser/changesViewActions.ts Revises toggle labels, state, and tooltips.
src/vs/editor/test/browser/widget/multiDiffEditorWidget.test.ts Tests responsive multi-diff behavior.
src/vs/editor/browser/widget/multiDiffEditor/multiDiffEditorWidgetImpl.ts Propagates diff layout options.
src/vs/editor/browser/widget/multiDiffEditor/multiDiffEditorWidget.ts Extends the layout override API.

Review details

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 9/9 changed files
  • Comments generated: 4
  • Review effort level: Balanced

Comment thread src/vs/sessions/contrib/changes/browser/changesViewActions.ts Outdated
Comment thread src/vs/sessions/contrib/changes/browser/sessionsChangesAccessibilityHelp.ts Outdated
Comment thread src/vs/sessions/contrib/changes/browser/changesViewActions.ts Outdated
Comment thread src/vs/sessions/contrib/editor/browser/diffEditor.sessions.contribution.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sandy081
Sandeep Somavarapu (sandy081) merged commit 8161484 into main Aug 20, 2026
27 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the sandy081/agents/responsive-inline-side-by-side-diff branch August 20, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants