Skip to content

Persist state between profiled startup runs #331860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit into from
Aug 20, 2026
Merged

Persist state between profiled startup runs #331860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/vs/workbench/contrib/performance/electron-browser/startupTimings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { IWorkspaceTrustManagementService } from '../../../../platform/workspace
import { IPaneCompositePartService } from '../../../services/panecomposite/browser/panecomposite.js';
import { StartupTimings } from '../browser/startupTimings.js';
import { coalesce } from '../../../../base/common/arrays.js';
import { IStorageService, WillSaveStateReason } from '../../../../platform/storage/common/storage.js';

interface ITracingData {
readonly args?: {
Expand Down Expand Up @@ -53,7 +54,8 @@ export class NativeStartupTimings extends StartupTimings implements IWorkbenchCo
@IUpdateService updateService: IUpdateService,
@INativeWorkbenchEnvironmentService private readonly _environmentService: INativeWorkbenchEnvironmentService,
@IProductService private readonly _productService: IProductService,
@IWorkspaceTrustManagementService workspaceTrustService: IWorkspaceTrustManagementService
@IWorkspaceTrustManagementService workspaceTrustService: IWorkspaceTrustManagementService,
@IStorageService private readonly _storageService: IStorageService,
) {
super(editorService, paneCompositeService, lifecycleService, updateService, workspaceTrustService);

Expand Down Expand Up @@ -128,7 +130,18 @@ export class NativeStartupTimings extends StartupTimings implements IWorkbenchCo
} catch (err) {
console.error(err);
} finally {
this._nativeHostService.exit(0);
let exitCode = 0;
try {
await Promise.race([
this._storageService.flush(WillSaveStateReason.SHUTDOWN),
timeout(5000).then(() => { throw new Error('Timed out flushing profiled startup state.'); }),
]);
} catch (error) {
exitCode = 1;
console.error(error);
} finally {
this._nativeHostService.exit(exitCode);
}
}
}

Expand Down