Skip to content

sessions: Respect metadata pill placement in chat tabs - #331870

Merged
Sandeep Somavarapu (sandy081) merged 2 commits into
mainfrom
sandy081/agents/fix-tabs-header-metadata
Aug 20, 2026
Merged

sessions: Respect metadata pill placement in chat tabs#331870
Sandeep Somavarapu (sandy081) merged 2 commits into
mainfrom
sandy081/agents/fix-tabs-header-metadata

Conversation

@sandy081

Copy link
Copy Markdown
Member

Summary

  • keep metadata pills hidden in the single-group tabs header when session metadata is configured above the chat input
  • mirror the existing SessionHeader visibility rule in ChatCompositeBar
  • add regression coverage with an actual contributed metadata menu item

Validation

  • ESLint
  • npm run typecheck-client
  • targeted ChatCompositeBar tests (9 passing)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 20, 2026 21:16
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.135.0 milestone Aug 20, 2026
@vs-code-engineering

vs-code-engineering Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/sessions/browser/parts/chatCompositeBar.ts
  • src/vs/sessions/browser/parts/chatGroupsView.ts
  • src/vs/sessions/browser/parts/media/chatCompositeBar.css
  • src/vs/sessions/browser/parts/sessionView.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Sessions chat tab header to honor metadata pill placement settings.

Changes:

  • Reactively hides header metadata pills when displayed above the chat input.
  • Adds regression coverage using a contributed metadata menu item.
Show a summary per file
File Description
src/vs/sessions/browser/parts/chatCompositeBar.ts Applies metadata placement configuration to pill visibility.
src/vs/sessions/test/browser/chatCompositeBar.test.ts Tests configured metadata pill hiding.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 5270254e Current: 9e0ca4a8

Changed (10)

sessions/chatCompositeBar/TwoChats/Dark
Before After
before after
sessions/chatCompositeBar/TwoChats/Light
Before After
before after
sessions/chatCompositeBar/MixedStatuses/Dark
Before After
before after
sessions/chatCompositeBar/MixedStatuses/Light
Before After
before after
sessions/chatCompositeBar/LongTitles/Dark
Before After
before after
sessions/chatCompositeBar/LongTitles/Light
Before After
before after
sessions/chatCompositeBar/Renaming/Dark
Before After
before after
sessions/chatCompositeBar/Renaming/Light
Before After
before after
sessions/chatCompositeBar/WithDraftChat/Dark
Before After
before after
sessions/chatCompositeBar/WithDraftChat/Light
Before After
before after

@sandy081
Sandeep Somavarapu (sandy081) merged commit 7edc21d into main Aug 20, 2026
27 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the sandy081/agents/fix-tabs-header-metadata branch August 20, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants