Use native metered connection monitor by dmitrivMS · Pull Request #331897 · microsoft/vscode

Dmitriy Vasyura (dmitrivMS) · 2026-08-21T03:56:51Z

load @vscode/metered in the Electron main process for native metered-connection detection
propagate the initial state and runtime changes to renderer and shared processes over the existing metered connection IPC channel
keep the browser Network Information implementation scoped to vscode.dev
add native-module packaging, import allowlisting, and regression coverage

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot · 2026-08-21T04:07:06Z

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Install dependencies

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Copilot

Pull request overview

Uses native OS metered-connection detection on desktop while retaining browser detection for vscode.dev.

Changes:

Adds @vscode/metered monitoring and IPC propagation.
Refactors browser and Electron metered services.
Adds packaging configuration and regression tests.

Show a summary per file

File	Description
`src/vs/platform/meteredConnection/test/electron-main/meteredConnectionMainService.test.ts`	Tests native monitoring lifecycle and updates.
`src/vs/platform/meteredConnection/test/electron-browser/meteredConnectionService.test.ts`	Tests IPC state synchronization.
`src/vs/platform/meteredConnection/electron-main/meteredConnectionMainService.ts`	Implements native OS monitoring.
`src/vs/platform/meteredConnection/electron-main/meteredConnectionChannel.ts`	Removes renderer-to-main state updates.
`src/vs/platform/meteredConnection/electron-browser/meteredConnectionService.ts`	Uses the main-process IPC state.
`src/vs/platform/meteredConnection/common/meteredConnectionIpc.ts`	Updates IPC commands and synchronization.
`src/vs/platform/meteredConnection/common/meteredConnection.ts`	Generalizes underlying connection state.
`src/vs/platform/meteredConnection/browser/meteredConnectionService.ts`	Scopes browser detection to web.
`src/vs/platform/environment/test/node/nativeModules.integrationTest.ts`	Verifies native module loading.
`src/vs/code/electron-main/app.ts`	Wires the native main service.
`package.json`	Adds and allowlists the dependency.
`package-lock.json`	Locks native module dependencies.
`eslint.config.js`	Allowlists the module import.
`build/.moduleignore`	Packages the native binary.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 13/14 changed files
Comments generated: 2
Review effort level: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files reviewed: 34/36 changed files
Comments generated: 1
Review effort level: Balanced

Copilot · 2026-08-21T09:28:43Z

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Install dependencies

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Mohammad javad Dianat (dianatofficial)

Verified the diff. Changes align with project standards.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-09-03T03:07:43Z

Base: c52a3884 Current: af8a445b

~~No screenshot changes.~~

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot · 2026-09-03T04:02:05Z

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Install dependencies

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Copilot

Copilot review overview

🟡 Changes recommended

Sysrooted Linux linking is broken, prerequisites are missing from other Linux build paths, and the proposed API documentation needs initialization qualification.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 · 2

New issues introduced by this change (2)

Severity	Finding
	`package.json` — Adding this native addon currently breaks Linux dependency installation under VS Code's sysrooted…
	`package.json` — The Linux build dependency for this native package is only added to three workflows. Other…

Pre-existing issues (1)

Severity	Finding
	`src/vs/code/electron-main/app.ts` — This wires telemetry only into the metered service; the main-process `TelemetryService` config at… View comment

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…e-metered

Copilot

Copilot review overview

🟡 Changes recommended

A critical buffering flaw can transmit telemetry generated while the connection was metered.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	`src/vs/platform/telemetry/common/telemetryService.ts` — Buffered events are classified only from the connection state at flush time. If the native monitor…

Issues resolved since last review (3)

Severity	Finding
	`package.json` — The Linux build dependency for this native package is only added to three workflows. Other… View resolved comment
	`package.json` — Adding this native addon currently breaks Linux dependency installation under VS Code's sysrooted… View resolved comment
	`src/vs/code/electron-main/app.ts` — This wires telemetry only into the metered service; the main-process `TelemetryService` config at… View resolved comment

+		// Buffer events until experiment properties and the initial metered connection state are available.
+		if (!this._isExperimentPropertySet || !this._isMeteredConnectionInitialized) {
 			if (this._pendingEvents.length < TelemetryService.MAX_BUFFER_SIZE) {
 				this._pendingEvents.push({ eventName, eventLevel, data });
 			}


Dmitriy Vasyura (dmitrivMS) · 2026-09-09T17:59:28Z


-		// Send all buffered events now that experiment properties are available
 		for (const event of this._pendingEvents) {
 			this._doLog(event.eventName, event.eventLevel, event.data);


AI Review: The new readiness buffer also affects telemetry services without experiment buffering, including the shared process. If telemetry.telemetryLevel changes from all to off (or error) while native initialization is pending, queued events are later replayed through _doLog, bypassing _log's current-level check. A source-based check reproduced usage and error events being appended after switching to off, and usage after switching to error. Please filter buffered events against the current telemetry level before replay and add coverage for a consent downgrade during initialization.

Dmitriy Vasyura (dmitrivMS) · 2026-09-09T17:59:28Z

 	public readonly onDidChangeIsConnectionMetered = this._onDidChangeIsConnectionMetered.event;

-	private _isConnectionMetered = false;
+	private _isConnectionMetered = true;


AI Review: This conservative pending value also reaches explicit preference changes. With extensions.autoUpdate='on', Disable Auto Update for Extensions remains available, but updateAutoUpdateForAllExtensions(false) calls the network-gated isAutoUpdateEnabled(), gets false, and returns before confirmation or changing the setting. On an unmetered startup with pending native initialization, the user's request is silently discarded and auto-updates remain enabled afterward. A source-based check reproduced this with the pending IPC client. Compare getAutoUpdateValue() !== 'off' when deciding whether an explicit preference change is redundant, and add a pending-initialization regression test. Keep the conservative network state for automatic work.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

meteredConnection: use native platform monitor

fdba6d4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings August 21, 2026 03:56

Dmitriy Vasyura (dmitrivMS) self-assigned this Aug 21, 2026

Dmitriy Vasyura (dmitrivMS) added the network Network related issues label Aug 21, 2026

Copilot started reviewing on behalf of Dmitriy Vasyura (dmitrivMS) August 21, 2026 03:59 View session

Dmitriy Vasyura (dmitrivMS) changed the title ~~meteredConnection: use native platform monitor~~ Use native metered connection monitor Aug 21, 2026

Copilot AI reviewed Aug 21, 2026

View reviewed changes

Comment thread src/vs/platform/meteredConnection/electron-main/meteredConnectionMainService.ts

Comment thread src/vs/platform/meteredConnection/common/meteredConnectionIpc.ts Outdated

meteredConnection: await initial state

aaa2313

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Dmitriy Vasyura (dmitrivMS) requested a balanced review from Copilot August 21, 2026 09:14

Copilot started reviewing on behalf of Dmitriy Vasyura (dmitrivMS) August 21, 2026 09:17 View session

Copilot AI reviewed Aug 21, 2026

View reviewed changes

Comment thread src/vs/code/electron-main/app.ts

Mohammad javad Dianat (dianatofficial) reviewed Aug 22, 2026

View reviewed changes

Dmitriy Vasyura (dmitrivMS) and others added 2 commits September 2, 2026 19:39

Merge main into dev/dmitriv/use-vscode-metered

4af7cb6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

meteredConnection: update package integrity

453e0ca

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

meteredConnection: fix Linux builds and lifecycle

08f2db3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Dmitriy Vasyura (dmitrivMS) requested a balanced review from Copilot September 3, 2026 03:49

Copilot started reviewing on behalf of Dmitriy Vasyura (dmitrivMS) September 3, 2026 03:50 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

Comment thread package.json

Comment thread package.json

Dmitriy Vasyura (dmitrivMS) commented Sep 3, 2026

View reviewed changes

Comment thread src/vs/code/electron-main/app.ts Outdated

Dmitriy Vasyura (dmitrivMS) mentioned this pull request Sep 3, 2026

Add GLib/GIO to Linux sysroots microsoft/vscode-linux-build-agent#63

Merged

Dmitriy Vasyura (dmitrivMS) and others added 4 commits September 2, 2026 23:00

meteredConnection: prepare Linux build dependencies

7591319

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

build: replace Debian 11 sanity coverage

79d7512

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge branch 'main' into dev/dmitriv/use-vscode-metered

5265ef3

build: use GLib-enabled Linux sysroots

7606f55

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Dmitriy Vasyura (dmitrivMS) mentioned this pull request Sep 8, 2026

Complete GLib sysroot development metadata microsoft/vscode-linux-build-agent#64

Merged

build: use complete GLib Linux sysroots

5552257

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into dev/dmitriv/use-vscod…

aa303a3

…e-metered

Dmitriy Vasyura (dmitrivMS) requested a balanced review from Copilot September 9, 2026 07:25

Copilot started reviewing on behalf of Dmitriy Vasyura (dmitrivMS) September 9, 2026 07:26 View session

Copilot AI reviewed Sep 9, 2026

View reviewed changes

Dmitriy Vasyura (dmitrivMS) commented Sep 9, 2026

View reviewed changes

build: update Linux package dependencies

cee5561

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Uh oh!

Conversation

Dmitriy Vasyura (dmitrivMS) commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Aug 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

Copilot AI commented Aug 21, 2026

Uh oh!

Mohammad javad Dianat (dianatofficial) left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Sep 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Dmitriy Vasyura (dmitrivMS) Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Dmitriy Vasyura (dmitrivMS) Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Dmitriy Vasyura (dmitrivMS) commented Aug 21, 2026 •

edited

Loading

github-actions Bot commented Sep 3, 2026 •

edited

Loading