Skip to content

sessions: disable unsupported editor splits - #331939

Merged
Sandeep Somavarapu (sandy081) merged 6 commits into
mainfrom
agents/disable-unsupported-split-agents-window
Aug 22, 2026
Merged

sessions: disable unsupported editor splits#331939
Sandeep Somavarapu (sandy081) merged 6 commits into
mainfrom
agents/disable-unsupported-split-agents-window

Conversation

@sandy081

Copy link
Copy Markdown
Member

Fixes #331470

Summary

  • add an editor-part capability that disables unsupported multi-group interactions only in the single-pane Agents Window main editor
  • hide and reject split/grid commands, keybindings, menus, drag-and-drop targets, open-to-side requests, restored layouts, and cross-part group moves/copies
  • preserve classic and normal editor layouts, auxiliary editor windows, and the separate multi-chat grid
  • document the single-group contract and add targeted regressions

Validation

  • npm run compile
  • npm run hygiene
  • npm run typecheck-client
  • npm run valid-layers-check
  • targeted Sessions unit tests (127 passing)
  • targeted ESLint

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 21, 2026 11:05
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.135.0 milestone Aug 21, 2026
@vs-code-engineering

vs-code-engineering Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/sessions/browser/parts/editorParts.ts
  • src/vs/sessions/browser/parts/singlePaneEditorPart.ts
  • src/vs/workbench/browser/parts/editor/editorDropTarget.ts
  • src/vs/workbench/services/editor/common/editorGroupsService.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enforces the single-group contract for the Agents Window’s single-pane main editor.

Changes:

  • Adds capability-based command, menu, and drag/drop restrictions.
  • Rejects group creation, multi-group layouts, and cross-part operations.
  • Adds documentation and regression tests.
Show a summary per file
File Description
src/vs/workbench/common/contextkeys.ts Defines the capability context key.
src/vs/workbench/browser/parts/editor/editorPart.ts Publishes per-part capability state.
src/vs/workbench/browser/parts/editor/editorDropTarget.ts Restricts split drop targets.
src/vs/workbench/browser/parts/editor/editorActions.ts Gates multi-group actions.
src/vs/workbench/browser/parts/editor/editor.contribution.ts Hides unsupported menu items.
src/vs/workbench/browser/contextkeys.ts Initializes the global context key.
src/vs/sessions/browser/workbench.ts Configures single-pane capability state.
src/vs/sessions/browser/parts/singlePaneEditorPart.ts Enforces one main editor group.
src/vs/sessions/browser/parts/editorParts.ts Restricts cross-part group operations.
src/vs/sessions/test/browser/workbench.test.ts Tests group restrictions.
src/vs/sessions/contrib/editor/test/browser/editor.contribution.test.ts Tests action and menu gating.
src/vs/sessions/LAYOUT.md Documents the editor invariant.
src/vs/sessions/SINGLE_PANE_SCENARIOS.md Records supported single-pane behavior.

Review details

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 13/13 changed files
  • Comments generated: 3
  • Review effort level: Balanced

Comment thread src/vs/workbench/browser/parts/editor/editorDropTarget.ts Outdated
Comment thread src/vs/sessions/browser/parts/editorParts.ts
Comment thread src/vs/sessions/browser/parts/singlePaneEditorPart.ts
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
auto-merge was automatically disabled August 21, 2026 14:58

Pull request was closed

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on this edge case. Fallback logic is robust.

@sandy081
Sandeep Somavarapu (sandy081) merged commit 49f9fd4 into main Aug 22, 2026
27 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the agents/disable-unsupported-split-agents-window branch August 22, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agents Window: Disable unsupported grid and split interactions in the single-pane layout

5 participants