sessions: disable unsupported editor splits - #331939
Merged
Sandeep Somavarapu (sandy081) merged 6 commits intoAug 22, 2026
Merged
sessions: disable unsupported editor splits#331939Sandeep Somavarapu (sandy081) merged 6 commits into
Sandeep Somavarapu (sandy081) merged 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
August 21, 2026 11:05
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
August 21, 2026 11:07
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Enforces the single-group contract for the Agents Window’s single-pane main editor.
Changes:
- Adds capability-based command, menu, and drag/drop restrictions.
- Rejects group creation, multi-group layouts, and cross-part operations.
- Adds documentation and regression tests.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/common/contextkeys.ts |
Defines the capability context key. |
src/vs/workbench/browser/parts/editor/editorPart.ts |
Publishes per-part capability state. |
src/vs/workbench/browser/parts/editor/editorDropTarget.ts |
Restricts split drop targets. |
src/vs/workbench/browser/parts/editor/editorActions.ts |
Gates multi-group actions. |
src/vs/workbench/browser/parts/editor/editor.contribution.ts |
Hides unsupported menu items. |
src/vs/workbench/browser/contextkeys.ts |
Initializes the global context key. |
src/vs/sessions/browser/workbench.ts |
Configures single-pane capability state. |
src/vs/sessions/browser/parts/singlePaneEditorPart.ts |
Enforces one main editor group. |
src/vs/sessions/browser/parts/editorParts.ts |
Restricts cross-part group operations. |
src/vs/sessions/test/browser/workbench.test.ts |
Tests group restrictions. |
src/vs/sessions/contrib/editor/test/browser/editor.contribution.test.ts |
Tests action and menu gating. |
src/vs/sessions/LAYOUT.md |
Documents the editor invariant. |
src/vs/sessions/SINGLE_PANE_SCENARIOS.md |
Records supported single-pane behavior. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 13/13 changed files
- Comments generated: 3
- Review effort level: Balanced
Dirk Bäumer (dbaeumer)
previously approved these changes
Aug 21, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…orted-split-agents-window
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Aiday Marlen Kyzy (aiday-mar)
approved these changes
Aug 21, 2026
auto-merge was automatically disabled
August 21, 2026 14:58
Pull request was closed
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
August 21, 2026 14:58
Mohammad javad Dianat (dianatofficial)
left a comment
There was a problem hiding this comment.
Great catch on this edge case. Fallback logic is robust.
Sandeep Somavarapu (sandy081)
deleted the
agents/disable-unsupported-split-agents-window
branch
August 22, 2026 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331470
Summary
Validation
npm run compilenpm run hygienenpm run typecheck-clientnpm run valid-layers-check