Browser: support tracking the host session id separately from agentic ownership - #332049
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces standalone host window IDs with structured browser host metadata, enabling future Agents Window session association.
Changes:
- Adds
IBrowserViewHostwith window and optional session IDs. - Propagates host metadata across main, shared, and renderer layers.
- Exposes host metadata through browser view models.
The host session ID is currently neither populated nor consumed, so independent session tracking remains incomplete.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/browserView/electron-browser/browserViewWorkbenchService.ts |
Passes structured host metadata into models and creation requests. |
src/vs/workbench/contrib/browserView/electron-browser/browserViewCDPService.ts |
Migrates CDP group creation to structured hosts. |
src/vs/workbench/contrib/browserView/common/browserView.ts |
Exposes host metadata on renderer models. |
src/vs/platform/browserView/node/playwrightService.ts |
Migrates Playwright groups to structured hosts. |
src/vs/platform/browserView/electron-main/browserViewMainService.ts |
Propagates host metadata through view creation. |
src/vs/platform/browserView/electron-main/browserViewGroup.ts |
Reads window IDs from structured hosts. |
src/vs/platform/browserView/electron-main/browserView.ts |
Stores host metadata on native views. |
src/vs/platform/browserView/common/browserView.ts |
Defines the shared host contract. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Balanced
Kyle Cutler (kycutler)
force-pushed
the
kycutler/hostsession
branch
from
August 21, 2026 22:22
18278e7 to
be86ef4
Compare
Kyle Cutler (kycutler)
force-pushed
the
kycutler/mutableowner
branch
from
August 21, 2026 22:22
37f0000 to
5776eb9
Compare
Mohammad javad Dianat (dianatofficial)
left a comment
Mohammad javad Dianat (dianatofficial)
left a comment
There was a problem hiding this comment.
Verified the diff. Changes align with project standards.
Kyle Cutler (kycutler)
force-pushed
the
kycutler/mutableowner
branch
from
September 1, 2026 21:23
5776eb9 to
eaeb542
Compare
Kyle Cutler (kycutler)
force-pushed
the
kycutler/hostsession
branch
from
September 1, 2026 21:33
be86ef4 to
fa97dc9
Compare
Kyle Cutler (kycutler)
force-pushed
the
kycutler/hostsession
branch
from
September 1, 2026 22:19
fa97dc9 to
0eb2e6b
Compare
Kyle Cutler (kycutler)
marked this pull request as ready for review
September 1, 2026 22:58
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Joaquín Ruales (@jruales)Matched files:
|
Kyle Cutler (kycutler)
enabled auto-merge (squash)
September 1, 2026 23:44
Vijay Upadya (vijayupadya)
approved these changes
Sep 2, 2026
roblourens
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.