Skip to content

Modern UI: Fix CSS specificity for tab action fading #332103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee Murray (mrleemurray) merged 3 commits into from
Aug 24, 2026
+68 −1
Merged

Modern UI: Fix CSS specificity for tab action fading #332103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fdeb79
Modern UI: Fix CSS specificity for tab action fading
na2co3-ftw Aug 22, 2026
9433800
Modern UI: Add tests for action background colors in editor tabs
na2co3-ftw Aug 22, 2026
21905a7
Fix comment
na2co3-ftw Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/vs/workbench/contrib/modernUI/browser/media/tabs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,12 +387,16 @@
bottom: 0;
width: var(--vscode-spacing-size160);
border-block: var(--vscode-strokeThickness) solid transparent;
background-image: linear-gradient(to right, transparent, var(--modern-ui-editor-tab-action-hover-background));
background-clip: padding-box;
box-sizing: border-box;
pointer-events: none;
}

.modern-ui-tabs.monaco-workbench:not(:is(.hc-black, .hc-light)) .part.editor > .content .editor-group-container > .title .tabs-container > .tab:not(.tab-actions-left):not(.close-action-off):hover > .tab-actions::before,
.modern-ui-tabs.monaco-workbench:not(:is(.hc-black, .hc-light)) .part.editor > .content .editor-group-container > .title .tabs-container > .tab:not(.tab-actions-left):not(.close-action-off) > .tab-actions:focus-within::before {
background-image: linear-gradient(to right, transparent, var(--modern-ui-editor-tab-action-hover-background));
Comment on lines +395 to +397

@na2co3-ftw na2co3 (na2co3-ftw) Aug 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added tests.
Some cases can not be unit tested, so I appended testing details to the PR description.

}

.modern-ui-tabs.monaco-workbench:not(:is(.hc-black, .hc-light)) .part.editor > .content .editor-group-container > .title .tabs-container > .tab.tab-actions-left:not(.close-action-off):hover > .tab-actions::before,
.modern-ui-tabs.monaco-workbench:not(:is(.hc-black, .hc-light)) .part.editor > .content .editor-group-container > .title .tabs-container > .tab.tab-actions-left:not(.close-action-off) > .tab-actions:focus-within::before {
right: auto;
Expand Down
63 changes: 63 additions & 0 deletions src/vs/workbench/contrib/modernUI/test/browser/modernUI.contribution.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,69 @@ suite('ModernUIContribution', () => {
});
});

test('applies the correct action background for each editor tab state', () => {
const root = document.createElement('div');
root.className = 'monaco-workbench modern-ui-tabs';
root.style.setProperty('--modern-ui-editor-tab-action-active-background', '#010203');
root.style.setProperty('--modern-ui-editor-tab-action-unfocused-active-background', '#040506');
root.style.setProperty('--modern-ui-editor-tab-action-hover-background', '#070809');
root.style.setProperty('--modern-ui-editor-tab-action-unfocused-hover-background', '#0A0B0C');
root.style.setProperty('--modern-ui-editor-tab-action-active-hover-background', '#0D0E0F');
root.style.setProperty('--modern-ui-editor-tab-action-unfocused-active-hover-background', '#101112');
root.style.setProperty('--vscode-modernEditorTab-selectedActionBackground', '#131415');
document.body.appendChild(root);
store.add(toDisposable(() => root.remove()));

const content = appendElement(appendElement(root, 'part editor'), 'content');
const activeGroup = appendElement(content, 'editor-group-container active');
const unfocusedGroup = appendElement(content, 'editor-group-container');
const getActionBackgroundColors = (group: HTMLElement, tabClassName: string) => {
const title = appendElement(group, 'title');
const tab = appendElement(appendElement(title, 'tabs-container'), tabClassName);
const actions = appendElement(tab, 'tab-actions');
const action = appendElement(actions, 'action-label');
action.tabIndex = 0;
action.focus();
return [
getWindow(actions).getComputedStyle(actions).backgroundColor,
getWindow(actions).getComputedStyle(actions, '::before').backgroundImage
];
};

assert.deepStrictEqual({
active: getActionBackgroundColors(activeGroup, 'tab active'),
activeLeft: getActionBackgroundColors(activeGroup, 'tab active tab-actions-left'),
unfocusedActive: getActionBackgroundColors(unfocusedGroup, 'tab active'),
unfocusedActiveLeft: getActionBackgroundColors(unfocusedGroup, 'tab active tab-actions-left'),
hover: getActionBackgroundColors(activeGroup, 'tab'),
hoverLeft: getActionBackgroundColors(activeGroup, 'tab tab-actions-left'),
unfocusedHover: getActionBackgroundColors(unfocusedGroup, 'tab'),
unfocusedHoverLeft: getActionBackgroundColors(unfocusedGroup, 'tab tab-actions-left'),
// Active hover states cannot be tested because they require the :hover state.
// activeHover: getActionBackgroundColors(activeGroup, 'tab active'),
// activeHoverLeft: getActionBackgroundColors(activeGroup, 'tab active tab-actions-left'),
// unfocusedActiveHover: getActionBackgroundColors(unfocusedGroup, 'tab active'),
// unfocusedActiveHoverLeft: getActionBackgroundColors(unfocusedGroup, 'tab active tab-actions-left'),
selected: getActionBackgroundColors(activeGroup, 'tab selected'),
selectedLeft: getActionBackgroundColors(activeGroup, 'tab selected tab-actions-left'),
}, {
active: ['rgb(1, 2, 3)', 'linear-gradient(to right, rgba(0, 0, 0, 0), rgb(1, 2, 3))'],
activeLeft: ['rgb(1, 2, 3)', 'linear-gradient(to left, rgba(0, 0, 0, 0), rgb(1, 2, 3))'],
unfocusedActive: ['rgb(4, 5, 6)', 'linear-gradient(to right, rgba(0, 0, 0, 0), rgb(4, 5, 6))'],
unfocusedActiveLeft: ['rgb(4, 5, 6)', 'linear-gradient(to left, rgba(0, 0, 0, 0), rgb(4, 5, 6))'],
hover: ['rgb(7, 8, 9)', 'linear-gradient(to right, rgba(0, 0, 0, 0), rgb(7, 8, 9))'],
hoverLeft: ['rgb(7, 8, 9)', 'linear-gradient(to left, rgba(0, 0, 0, 0), rgb(7, 8, 9))'],
unfocusedHover: ['rgb(10, 11, 12)', 'linear-gradient(to right, rgba(0, 0, 0, 0), rgb(10, 11, 12))'],
unfocusedHoverLeft: ['rgb(10, 11, 12)', 'linear-gradient(to left, rgba(0, 0, 0, 0), rgb(10, 11, 12))'],
// activeHover: ['rgb(13, 14, 15)', 'linear-gradient(to right, rgba(0, 0, 0, 0), rgb(13, 14, 15))'],
// activeHoverLeft: ['rgb(13, 14, 15)', 'linear-gradient(to left, rgba(0, 0, 0, 0), rgb(13, 14, 15))'],
// unfocusedActiveHover: ['rgb(16, 17, 18)', 'linear-gradient(to right, rgba(0, 0, 0, 0), rgb(16, 17, 18))'],
// unfocusedActiveHoverLeft: ['rgb(16, 17, 18)', 'linear-gradient(to left, rgba(0, 0, 0, 0), rgb(16, 17, 18))'],
selected: ['rgb(19, 20, 21)', 'linear-gradient(to right, rgba(0, 0, 0, 0), rgb(19, 20, 21))'],
selectedLeft: ['rgb(19, 20, 21)', 'linear-gradient(to left, rgba(0, 0, 0, 0), rgb(19, 20, 21))'],
});
});

test('uses legacy color customizations for Modern UI editor tabs only', () => {
const theme = ColorThemeData.createUnloadedTheme('vs-dark', {
[editorBackground]: '#000000',
Expand Down
Loading