agentHost: clarify metadata lint boundary - #333010
Merged
roblourens merged 4 commits intoSep 8, 2026
Merged
Conversation
Remove per-line untyped metadata lint suppressions by making common/meta the explicit validation boundary. Isolate the Copilot SDK's typed metadata access in a dedicated adapter.\n\n(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
.github/instructions/agentHostTesting.instructions.md — This guidance describes an invariant the tree does not currently satisfy. Protocol _meta readers… |
What changed in this PR
Clarifies the intended validation boundary for Agent Host protocol metadata.
Changes:
- Exempts validating metadata readers from the lint rule.
- Moves Codex metadata parsing under
common/meta. - Isolates typed Copilot SDK metadata access in an adapter.
| File | Description |
|---|---|
.eslint-plugin-local/code-no-untyped-meta-access.ts |
Updates rule guidance. |
.github/instructions/agentHostTesting.instructions.md |
Documents the metadata boundary. |
eslint.config.js |
Adds scoped lint exclusions. |
src/vs/platform/agentHost/common/codexAccount.ts |
Preserves the existing import path. |
src/vs/platform/agentHost/common/meta/agentChatSurfaceMeta.ts |
Removes inline suppression. |
src/vs/platform/agentHost/common/meta/agentElementAttachments.ts |
Uses hasKey for narrowing. |
src/vs/platform/agentHost/common/meta/agentEphemeralSessionMeta.ts |
Removes inline suppression. |
src/vs/platform/agentHost/common/meta/agentFeedbackAttachments.ts |
Removes inline suppression. |
src/vs/platform/agentHost/common/meta/agentMessageDelegationMeta.ts |
Removes inline suppression. |
src/vs/platform/agentHost/common/meta/agentSnapshotAttachmentMeta.ts |
Removes inline suppression. |
src/vs/platform/agentHost/common/meta/browserViewAttachments.ts |
Removes inline suppression. |
src/vs/platform/agentHost/common/meta/clientPluginCustomizationMeta.ts |
Removes inline suppression. |
src/vs/platform/agentHost/common/meta/codexAccount.ts |
Houses Codex metadata validation. |
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts |
Uses the SDK metadata adapter. |
src/vs/platform/agentHost/node/copilot/copilotSdkMeta.ts |
Isolates typed SDK metadata access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use a type predicate compatible with tsgo and clarify that the common/meta convention applies to new namespaced readers while legacy readers await migration.\n\n(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
marked this pull request as ready for review
September 8, 2026 19:10
roblourens
enabled auto-merge (squash)
September 8, 2026 19:10
…ule-disable-instructions-update
The metadata boundary is now excluded from the rule, so suppressions added on main became unused and failed hygiene.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Aaron Munger (amunger)
approved these changes
Sep 8, 2026
roblourens
deleted the
roblou/agents/islin-rule-disable-instructions-update
branch
September 8, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove per-line untyped metadata lint suppressions by making common/meta the explicit validation boundary. Isolate the Copilot SDK's typed metadata access in a dedicated adapter.\n\n(Written by Copilot)
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com