Address follow up customization modal redesign PR feedback - #333027
Merged
Hawk Ticehurst (hawkticehurst) merged 5 commits intoAug 27, 2026
Conversation
Copilot started reviewing on behalf of
Hawk Ticehurst (hawkticehurst)
August 27, 2026 19:45
View session
Hawk Ticehurst (hawkticehurst)
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses follow-up reliability issues in the redesigned AI Customizations editor.
Changes:
- Adds cancellation and stale-request protection for plugin, MCP, and editor navigation flows.
- Improves plugin installation/uninstallation discovery and result handling.
- Adds focused regression tests for the updated behavior.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
aiCustomizationManagementEditor.fixture.ts |
Updates plugin removal mock. |
pluginListWidget.test.ts |
Tests marketplace request freshness. |
mcpListWidget.test.ts |
Tests access gating and durable enablement. |
embeddedAgentPluginDetail.test.ts |
Tests asynchronous install discovery. |
aiCustomizationManagementEditor.test.ts |
Tests stale navigation rejection. |
agentPluginActions.test.ts |
Tests removal result propagation. |
agentPluginServiceImpl.ts |
Makes removal asynchronous and result-bearing. |
agentPluginService.ts |
Updates the plugin removal contract. |
pluginListWidget.ts |
Adds race handling and reactive toggle state. |
mcpListWidget.ts |
Adds access-aware cancellation and enablement handling. |
embeddedAgentPluginDetail.ts |
Waits for installed-plugin discovery and handles uninstall results. |
aiCustomizationManagementEditor.ts |
Guards asynchronous contribution navigation. |
aiCustomizationManagement.contribution.ts |
Awaits plugin removal. |
agentPluginActions.ts |
Exposes uninstall results to callers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Aug 27, 2026
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersSearch/Light
| Before | After |
|---|---|
 |
 |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hawk Ticehurst (hawkticehurst)
enabled auto-merge (squash)
August 27, 2026 22:12
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 27, 2026
Hawk Ticehurst (hawkticehurst)
deleted the
agents/review-unresolved-pr-feedback
branch
August 27, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #322043
This pull request addresses the unresolved feedback from Dmitriy Vasyura (@dmitrivMS) provided after PR merge, following the recent redesign of the customizations modal in the agents/editor windows. Key changes include:
pluginListWidget.ts.embeddedAgentPluginDetail.ts.mcpListWidget.ts.aiCustomizationManagementEditor.ts.All changes have been validated with successful transpilation and passing tests. This PR aims to ensure that the issues identified are resolved while maintaining the integrity of the existing functionality.