fix: memory leak in markers table - #333241
Merged
Ulugbek Abdullaev (ulugbekna) merged 1 commit intoSep 7, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Simon Siefke (SimonSiefke)
August 28, 2026 19:59
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Registers the inner WorkbenchTable with MarkersTable so mode switches correctly dispose table-owned resources and prevent memory leaks.
Changes:
- Adds
WorkbenchTableto the owner’s disposable lifecycle.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sandeep Somavarapu (sandy081)
approved these changes
Sep 1, 2026
Giuseppe Cianci (Giuspepe)
approved these changes
Sep 1, 2026
Ulugbek Abdullaev (ulugbekna)
approved these changes
Sep 1, 2026
Ulugbek Abdullaev (ulugbekna)
enabled auto-merge (squash)
September 2, 2026 12:04
Ulugbek Abdullaev (ulugbekna)
merged commit Sep 7, 2026
6dddc81
into
microsoft:main
62 of 75 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
MarkersTablecreated its innerWorkbenchTableoutside its disposable store. Switching Problems between table and tree views therefore retained the table's DOM listeners, sashes, scrollbars, and renderers.Change
Register the inner table with
MarkersTableso it is disposed together with its owner.Before
When switching the Problems view between table and tree modes for 37 cycles, 217 named-function rows remain retained, including 2,479
DomListenerinstances:After
No more markers table leak is detected. The matching 37-cycle result contains zero retained named-function rows.
Test Video
test-video.webm