Wire eagernessPrompt in from /models - #333279
Draft
Benjamin Steenhoek (bstee615) wants to merge 2 commits into
Draft
Wire eagernessPrompt in from /models#333279Benjamin Steenhoek (bstee615) wants to merge 2 commits into
Benjamin Steenhoek (bstee615) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Benjamin Steenhoek (bstee615)
August 28, 2026 23:15
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Wires model-provided inline-edit eagerness prompts from Proxy responses into model configuration.
Changes:
- Validates the optional
capabilities.eagernessPrompt. - Propagates only the supported
aggressionHighLowvalue. - Enables eagerness handling for
PatchBased02Optimizedwith tests.
| File | Description |
|---|---|
proxyModelsService.spec.ts |
Tests optional capability validation. |
xtabPromptOptions.spec.ts |
Tests optimized-strategy recognition. |
inlineEditsModelService.ts |
Propagates supported prompt values. |
xtabPromptOptions.ts |
Enables the optimized strategy path. |
inlineEditsModelsTypes.ts |
Extends Proxy wire validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Benjamin Steenhoek (bstee615)
changed the title
Treat the optimized PatchBased02 unified strategy as eagerness-aware when a model supplies an eagerness prompt, while preserving non-eagerness behavior for unrelated strategies. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2bce40ed-b23b-4b38-8c2a-11a9b30a08ce
Benjamin Steenhoek (bstee615)
force-pushed
the
bstee615-wire-models-eagerness-prompt
branch
from
August 31, 2026 18:40
926015e to
ae187fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capabilities.eagernessPromptstring from Proxy/modelsresponsesaggressionHighLowvalue into fetched inline edits model configuration without fabricating a fallbackDependencies
PatchBased02Unifiedas a model-provided eagerness strategycapabilities.eagernessPromptfrom/modelsmainincludes that shared dependency commit because GitHub cannot formally base an upstream PR on a fork branchValidation
npm run typecheckinextensions/copilotgit diff --check; root hygiene excludesextensions/copilot/**by design