Add PatchBased02UnifiedEagerness prompt strategy - #333302
Draft
Benjamin Steenhoek (bstee615) wants to merge 5 commits into
Draft
Add PatchBased02UnifiedEagerness prompt strategy#333302Benjamin Steenhoek (bstee615) wants to merge 5 commits into
Benjamin Steenhoek (bstee615) wants to merge 5 commits into
Conversation
Copilot started reviewing on behalf of
Benjamin Steenhoek (bstee615)
August 29, 2026 02:50
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
extensions/copilot/src/platform/inlineEdits/common/dataTypes/xtabPromptOptions.ts — This standalone strategy does not inherit the configuration baked into PatchBased02Optimized; it… |
 |
extensions/copilot/src/platform/inlineEdits/test/common/xtabPromptOptions.spec.ts — The same assertion is executed twice, so the second line adds no coverage and may conceal an… |
What changed in this PR
Adds a standalone four-in-one eagerness prompting strategy for inline edits and applies strategy configuration during default-model retries.
Changes:
- Adds and configures
PatchBased02OptimizedFourInOne. - Supports its prompt construction, response format, and system prompt.
- Adds focused configuration, prompt, and retry tests.
| File | Description |
|---|---|
xtabPromptOptions.ts |
Defines and configures the strategy. |
xtabPromptOptions.spec.ts |
Tests strategy configuration. |
xtabProvider.ts |
Applies configuration on fallback and selects its prompt. |
xtabProvider.spec.ts |
Tests propagation and fallback behavior. |
promptCrafting.ts |
Builds four-in-one prompts. |
promptCrafting.spec.ts |
Tests eagerness-tag placement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+835
to
+837
| [PromptingStrategy.PatchBased02OptimizedFourInOne]: { | ||
| eagernessPrompt: 'aggressionHighLow', | ||
| }, |
Comment on lines
+182
to
+183
| expect(isEagernessPrompt(options)).toBe(true); | ||
| expect(isEagernessPrompt(options)).toBe(true); |
Benjamin Steenhoek (bstee615)
changed the title
Treat the optimized PatchBased02 unified strategy as eagerness-aware when a model supplies an eagerness prompt, while preserving non-eagerness behavior for unrelated strategies. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add the standalone PatchBased02OptimizedEagerness strategy and apply its configuration on default-model retries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 13bd697b-ebe3-4c55-a34e-58dcf027cad6
Benjamin Steenhoek (bstee615)
force-pushed
the
bstee615-add-four-in-one-strategy
branch
from
August 31, 2026 18:35
cd6c7f8 to
762e6c2
Compare
Define PatchBased02UnifiedEagerness from the exact Unified configuration with eagernessPrompt as its sole difference. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 13bd697b-ebe3-4c55-a34e-58dcf027cad6
Benjamin Steenhoek (bstee615)
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 13bd697b-ebe3-4c55-a34e-58dcf027cad6
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 13bd697b-ebe3-4c55-a34e-58dcf027cad6
Benjamin Steenhoek (bstee615)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the standalone
PatchBased02UnifiedEagernessprompting strategy -- clone ofPatchBased02UnifiedwitheagernessPrompt: "aggressionHighLow".Depends on #333606