extensions/copilot: Enhance robustness of dynamic ESLint rule loader - #333353
Open
Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Open
extensions/copilot: Enhance robustness of dynamic ESLint rule loader#333353Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Conversation
Add try-catch blocks and module validation around dynamic rule loading in the Copilot ESLint plugin index to prevent initialization crashes from unhandled file system or import exceptions.
Copilot started reviewing on behalf of
Deniz Güney Yıldırım (denizguney)
August 29, 2026 20:54
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Improves resilience of the Copilot-local ESLint rule loader.
Changes:
- Catches directory-read and rule-import failures.
- Registers rules only when a default export exists.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+19
to
+23
| if (ruleModule.default) { | ||
| rules[path.basename(file, '.ts')] = ruleModule.default; | ||
| } | ||
| } catch (error) { | ||
| console.error(`Failed to load ESLint rule from ${file}:`, error); |
…e loader Replace silent catch blocks with explicit fail-fast error throwing and default export validation to prevent cascading configuration errors in eslint.config.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add try-catch blocks and module validation around dynamic rule loading in the Copilot ESLint plugin index to prevent initialization crashes from unhandled file system or import exceptions.