Fix Update Button Visibility and Position in Agents Window - #333473
Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit intoAug 31, 2026
Conversation
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 31, 2026 07:53
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 31, 2026 07:53
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
src/vs/sessions/contrib/accountMenu/browser/account.contribution.ts — Moving the entry into TitleBarLeftLayout drops the overflow recalculation that the removed… |
|
src/vs/sessions/contrib/accountMenu/browser/account.contribution.ts — The regression condition removed here is not covered by the updated tests.… |
What changed in this PR
Moves the Agents Window Update action to the left title bar while preserving editor placement behavior.
Changes:
- Removes session/commit eligibility visibility constraints.
- Uses placement-specific tooltip alignment.
- Removes the obsolete right-side toolbar and styling.
| File | Description |
|---|---|
updateTitleBarEntry.test.ts |
Tests left-aligned focused tooltip behavior. |
updateTitleBarEntry.ts |
Supports placement-specific tooltip alignment. |
account.contribution.ts |
Registers Update in the Agents left toolbar. |
titlebarPart.ts |
Removes the dedicated right-side Update toolbar. |
titlebarpart.css |
Removes obsolete Update toolbar spacing. |
menus.ts |
Removes the obsolete Update menu identifier. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dirk Bäumer (dbaeumer)
approved these changes
Aug 31, 2026
Martin Aeschlimann (aeschli)
approved these changes
Aug 31, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
agents/fix-update-button-agents-window
branch
August 31, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request addresses the visibility and positioning of the Update button in the Agents window. The changes made include: - Visibility Fix: The Update button is now always visible in the Agents window, regardless of active sessions or the Commit action eligibility. - Position Adjustment: The Update button has been moved to the left side of the title bar, following the existing layout actions, to reduce crowding on the right side. - Tooltip Alignment: The tooltip for the Update button is now aligned correctly based on its placement—left-aligned in the Agents window and right-aligned in the editor title bar. ### Changes Summary: - Updated visibility logic in
account.contribution.ts. - Moved Update button to the left title bar intitlebarPart.ts. - Adjusted tooltip alignment inupdateTitleBarEntry.ts. - Removed unused right-side toolbar and related CSS. ### Validation: - Typecheck and all relevant tests have passed successfully.Screenshot