test: Speed up Electron unit tests in CI - #333495
Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits intoAug 31, 2026
Merged
Conversation
Keep the unit-test renderer unthrottled and show its window without activating it on CI. This avoids Chromium throttling requestAnimationFrame for a hidden Windows window. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 31, 2026 09:25
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Speeds up Electron unit tests in CI by preventing animation-frame throttling while retaining hidden windows locally.
Changes:
- Disables renderer background throttling.
- Shows the CI test window without activating it.
| File | Description |
|---|---|
test/unit/electron/index.js |
Configures CI-aware test-window visibility and throttling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Alexandru Dima (alexdima)
approved these changes
Aug 31, 2026
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 31, 2026 09:58
Dmitriy Vasyura (dmitrivMS)
added
the
engineering
Aiday Marlen Kyzy (aiday-mar)
approved these changes
Aug 31, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
agents/ci-performance-analysis-and-improvements
branch
August 31, 2026 14:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speeds up Electron unit tests that wait for animation frames by preventing the test renderer from being treated as a hidden background window in CI.
BrowserWindowOn Windows,
backgroundThrottling: falsealone does not prevent Chromium from throttlingrequestAnimationFramein a hidden window. In the sampled CI run, 11 frame-driven tests took 94.9 seconds in Electron versus 1.5 seconds in browser tests.Validation
npm run compiletest/unit/electron/index.jsFull
npm run hygienecould not start on Windows becausebuild/gulpfile.hygiene.tsresolved the repository path asC:\C:\repos\...\remote\package.json; the targeted hygiene check passed.