Avoid Agent Host session listing starvation - #333579
Merged
Benjamin Christopher Simmonds (benibenj) merged 3 commits intoAug 31, 2026
Merged
Avoid Agent Host session listing starvation#333579Benjamin Christopher Simmonds (benibenj) merged 3 commits into
Benjamin Christopher Simmonds (benibenj) merged 3 commits into
Conversation
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
August 31, 2026 16:03
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
August 31, 2026 16:04
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 2
New issues introduced by this change (3)
| Severity | Finding |
|---|---|
 |
src/vs/platform/agentHost/node/agentService.ts — This still permits the expensive scans to overlap: _invalidateSessionList() clears the map, so… |
|
.eslint-plugin-local/code-no-bracket-notation-for-identifiers.ts — The numeric special case misses signed numbers because -1 and +1 are UnaryExpression nodes,… |
 |
package.json — This release-version bump is outside the stated Agent Host starvation fix, as are the formatter… |
What changed in this PR
Updates Agent Host session discovery and Recent-mode persistence to reduce listing starvation. The PR also includes several unrelated UI, formatting, lint, and release changes.
Changes:
- Defers provider discovery and persists the Recent-mode cutoff.
- Adjusts Sessions UI, action widgets, formatting, tunnels, and Markdown preview behavior.
- Advances VS Code and Copilot versions and adds an ESLint rule.
| File | Description |
|---|---|
src/vs/workbench/contrib/update/test/browser/updateTitleBarEntry.test.ts |
Tests configurable hover alignment. |
src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts |
Supports placement-specific hover alignment. |
src/vs/workbench/contrib/format/test/browser/formatActionsMultiple.test.ts |
Tests formatter-ID arguments. |
src/vs/workbench/contrib/format/browser/formatActionsMultiple.ts |
Allows direct formatter selection. |
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Updates Recent-mode description. |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostActions.ts |
Sorts tunnels by name. |
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHost/agentHostSessionConfigPicker.test.ts |
Tests branch Changes action. |
src/vs/sessions/contrib/providers/agentHost/browser/agentHostSessionConfigPicker.ts |
Adds branch Changes shortcut. |
src/vs/sessions/contrib/accountMenu/browser/account.contribution.ts |
Moves update indicator left. |
src/vs/sessions/browser/parts/titlebarPart.ts |
Removes dedicated update toolbar. |
src/vs/sessions/browser/parts/media/titlebarpart.css |
Removes obsolete update spacing. |
src/vs/sessions/browser/menus.ts |
Removes update menu ID. |
src/vs/platform/agentHost/test/node/copilotAgent.test.ts |
Explicitly starts discovery. |
src/vs/platform/agentHost/test/node/codex/codexModelRefresh.test.ts |
Tests requested Codex discovery. |
src/vs/platform/agentHost/test/node/claudeAgent.test.ts |
Explicitly starts discovery. |
src/vs/platform/agentHost/test/node/agentService.test.ts |
Covers discovery and cutoff persistence. |
src/vs/platform/agentHost/node/copilot/copilotAgent.ts |
Exposes explicit discovery start. |
src/vs/platform/agentHost/node/codex/codexAgent.ts |
Tracks requested discovery. |
src/vs/platform/agentHost/node/claude/claudeAgent.ts |
Exposes explicit discovery start. |
src/vs/platform/agentHost/node/agentService.ts |
Revises listing, discovery, and Recent cutoff handling. |
src/vs/platform/agentHost/common/agentHostSchema.ts |
Updates Recent-mode description. |
src/vs/platform/agentHost/common/agent.ts |
Adds discovery-start provider API. |
src/vs/platform/agentHost/AGENTS.md |
Documents discovery lifecycle. |
src/vs/platform/actionWidget/test/browser/actionList.test.ts |
Tests detail-toolbar layout. |
src/vs/platform/actionWidget/browser/actionWidget.css |
Stabilizes detail toolbar geometry. |
src/vs/platform/actionWidget/browser/actionList.ts |
Tracks details and adjusts width measurement. |
package.json |
Advances VS Code version. |
package-lock.json |
Synchronizes root lockfile version. |
extensions/markdown-language-features/preview-src/index.ts |
Resets cross-resource scrolling. |
extensions/copilot/package.json |
Advances Copilot and engine versions. |
extensions/copilot/package-lock.json |
Synchronizes Copilot lockfile metadata. |
.vscode/notebooks/my-endgame.github-issues |
Advances milestone query. |
.vscode/notebooks/endgame.github-issues |
Advances milestone query. |
.eslint-plugin-local/code-no-bracket-notation-for-identifiers.ts |
Adds bracket-notation lint rule. |
Files not reviewed (1)
- extensions/copilot/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Base:
|
Defer external session discovery, persist recent local-session cutoffs, and prevent stale catalog epochs from repeatedly restarting expensive listings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
force-pushed
the
benibenj/agent-host-session-listing
branch
from
August 31, 2026 18:03
2994e7d to
62392b8
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep expensive session-list computations coalesced when invisible provisional composers are created or disposed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
force-pushed
the
benibenj/agent-host-session-listing
branch
from
August 31, 2026 20:46
037e3e9 to
87d3c01
Compare
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 31, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Aug 31, 2026
6e1c256
into
release/1.136
54 of 61 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/agent-host-session-listing
branch
August 31, 2026 21:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #333284.
Validation