sessions: Disable unavailable session type picker - #333603
Merged
Megan Rogge (meganrogge) merged 2 commits intoAug 31, 2026
Merged
Conversation
Keep the sole session type visible for context while preventing interaction when no alternative can be selected. Re-enable the picker reactively when another type becomes available.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
marked this pull request as ready for review
August 31, 2026 17:52
Megan Rogge (meganrogge)
marked this pull request as draft
August 31, 2026 17:53
Megan Rogge (meganrogge)
marked this pull request as ready for review
August 31, 2026 17:53
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/browser/sessionTypePicker.ts — Keeping this target visible exposes it to the V2 onboarding tour: newSessionViewV2Tour.ts's… |
What changed in this PR
Keeps a sole session-type pill visible while disabling interaction until alternatives become available.
Changes:
- Adds disabled styling, ARIA state, and keyboard behavior.
- Adds regression coverage for disabled-to-enabled transitions.
- Removes web-only hiding behavior.
| File | Description |
|---|---|
sessionTypePicker.ts |
Updates pill visibility and interactivity. |
sessionTypePicker.test.ts |
Tests single- and multiple-type states. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gate the V2 harness spotlight on the picker interaction context so a visible but disabled sole session type is not presented as an actionable tour step.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Henning Dieterichs (hediet)
approved these changes
Aug 31, 2026
Megan Rogge (meganrogge)
deleted the
agents/cloud-pill-selection-issue-fix
branch
August 31, 2026 19:33
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run transpile-client./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/sessionTypePicker.test.ts(26 passing)Fixes #333605