sessions: add chevrons to new session pills - #333608
Merged
Megan Rogge (meganrogge) merged 2 commits intoAug 31, 2026
Merged
Conversation
Replace the Issue/PR plus with the same dropdown affordance used by the harness and workspace pickers.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
previously approved these changes
Aug 31, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Adds compact dropdown chevrons to the new-session picker pills while preserving existing borders and picker accessibility.
Changes:
- Shows compact chevrons on harness and workspace-category pills.
- Removes the Issue/PR plus icon.
- Updates focused unit-test snapshots.
| File | Description |
|---|---|
src/vs/sessions/contrib/chat/browser/newChatWidget.ts |
Enables the harness chevron and removes the Issue/PR icon. |
src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts |
Supports iconless triggers and renders category chevrons. |
src/vs/sessions/contrib/chat/browser/media/chatWidget.css |
Sizes category chevrons using the compact token. |
src/vs/sessions/contrib/chat/test/browser/newChatWidget.test.ts |
Updates trigger configuration expectations. |
src/vs/sessions/contrib/chat/test/browser/sessionWorkspacePicker.test.ts |
Verifies category chevron rendering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (28)1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d31eaa8-0167-4e21-9b96-54e229afb71e
Henning Dieterichs (hediet)
approved these changes
Aug 31, 2026
Megan Rogge (meganrogge)
deleted the
agents/remove-plus-add-chevron-pills
branch
August 31, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run eslint -- src/vs/sessions/contrib/chat/browser/newChatWidget.ts src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts src/vs/sessions/contrib/chat/test/browser/newChatWidget.test.ts src/vs/sessions/contrib/chat/test/browser/sessionWorkspacePicker.test.ts