Skip to content

sessions: add chevrons to new session pills - #333608

Merged
Megan Rogge (meganrogge) merged 2 commits into
mainfrom
agents/remove-plus-add-chevron-pills
Aug 31, 2026
Merged

sessions: add chevrons to new session pills#333608
Megan Rogge (meganrogge) merged 2 commits into
mainfrom
agents/remove-plus-add-chevron-pills

Conversation

@meganrogge

@meganrogge Megan Rogge (meganrogge) commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator
Image

Summary

  • add compact dropdown chevrons to the new-session harness, workspace, and Issue/PR pills
  • remove the plus icon from the Issue/PR pill
  • keep the existing pill borders and accessible picker behavior

Validation

  • npm run eslint -- src/vs/sessions/contrib/chat/browser/newChatWidget.ts src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts src/vs/sessions/contrib/chat/test/browser/newChatWidget.test.ts src/vs/sessions/contrib/chat/test/browser/sessionWorkspacePicker.test.ts
  • 103 focused unit tests passing
  • verified all three pill icons and borders in a live Code OSS Agents window

Replace the Issue/PR plus with the same dropdown affordance used by the harness and workspace pickers.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 31, 2026 18:16
@meganrogge
Megan Rogge (meganrogge) enabled auto-merge (squash) August 31, 2026 18:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Adds compact dropdown chevrons to the new-session picker pills while preserving existing borders and picker accessibility.

Changes:

  • Shows compact chevrons on harness and workspace-category pills.
  • Removes the Issue/PR plus icon.
  • Updates focused unit-test snapshots.
File Description
src/​vs/​sessions/​contrib/​chat/​browser/​newChatWidget.ts Enables the harness chevron and removes the Issue/PR icon.
src/​vs/​sessions/​contrib/​chat/​browser/​sessionWorkspacePicker.ts Supports iconless triggers and renders category chevrons.
src/​vs/​sessions/​contrib/​chat/​browser/​media/​chatWidget.css Sizes category chevrons using the compact token.
src/​vs/​sessions/​contrib/​chat/​test/​browser/​newChatWidget.test.ts Updates trigger configuration expectations.
src/​vs/​sessions/​contrib/​chat/​test/​browser/​sessionWorkspacePicker.test.ts Verifies category chevron rendering.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 374ea56f Current: 8416595a

Changed (28)

sessions/chat/newWidget/newChatWidget/NewSessionDefault/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionDefault/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionNarrow/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionNarrow/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionComments/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionComments/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionTip/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/NewSessionTip/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsLoading/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsLoading/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsStandard/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsStandard/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsGitHubMixed/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsGitHubMixed/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsSelected/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsSelected/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsEditedDisabled/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsEditedDisabled/Light
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsNarrow/Dark
Before After
before after
sessions/chat/newWidget/newChatWidget/PromptOptionsNarrow/Light
Before After
before after

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8d31eaa8-0167-4e21-9b96-54e229afb71e
@meganrogge
Megan Rogge (meganrogge) merged commit 752a80f into main Aug 31, 2026
37 checks passed
@meganrogge
Megan Rogge (meganrogge) deleted the agents/remove-plus-add-chevron-pills branch August 31, 2026 19:08
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants