[cherry-pick] nes: fix: normalize Windows workspace path casing - #333610
Closed
vs-code-engineering[bot] wants to merge 1 commit into
Closed
[cherry-pick] nes: fix: normalize Windows workspace path casing#333610vs-code-engineering[bot] wants to merge 1 commit into
vs-code-engineering[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows NES path matching by normalizing drive-letter casing while preserving other path casing.
Changes:
- Normalize Windows drive letters during workspace-relative path comparison.
- Preserve notebook fragments and virtual-path case sensitivity.
- Add Windows coverage for prompts, notebooks, and progressive patch reveal.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
promptCraftingUtils.ts |
Normalizes drive-letter casing for relative paths. |
xtabProvider.spec.ts |
Tests Windows and notebook path handling. |
xtabPatchResponseHandler.spec.ts |
Tests progressive edits for Windows paths with spaces. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Henning Dieterichs (hediet)
approved these changes
Aug 31, 2026
roblourens
approved these changes
Aug 31, 2026
Vritant Bhardwaj (vritant24)
approved these changes
Aug 31, 2026
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 31, 2026
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 31, 2026
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 31, 2026
Don Jayamanne (DonJayamanne)
approved these changes
Aug 31, 2026
Member
|
Ulugbek Abdullaev (@ulugbekna) since we are now past endgame, does this need to still be taken in this release or can this flow into next week's release? |
Anthony Kim (anthonykim1)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #333429 from
main.Fixes #325491
Root cause
NES creates its document ID from
doc.uri.toString(). On Windows, URI serialization lowercases the drive letter, producing/c:/workspace/..., while the workspace-folder URI can retain/C:/workspace.toUniquePathcompared these paths case-sensitively, failed to strip the workspace root, and leaked an absolute drive path into the Lysithea prompt and speculative prediction.The first native Windows CI run reproduced this exactly:
Fix
Validation
Copilot - Test (Windows).The draft-only
VS Code PR Checkpolicy remains pending.