Skip to content

Fix card colors in customization modal for better theme contrast #333620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hawk Ticehurst (hawkticehurst) merged 3 commits into from
Aug 31, 2026
Merged

Fix card colors in customization modal for better theme contrast #333620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6c9164
Agent Host changes for agents/fix-customization-modal-card-colors
hawkticehurst Aug 31, 2026
a932abe
Preserve customization card row separators
hawkticehurst Aug 31, 2026
e35ad02
Update customization screenshot baselines
hawkticehurst Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...workbench/contrib/chat/browser/aiCustomization/media/agentGlobalConfigurationSettings.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
}

.agent-global-configuration-settings-card {
border: 1px solid var(--vscode-widget-border, var(--vscode-contrastBorder, transparent));
border: var(--vscode-strokeThickness) solid var(--vscode-agentsPanel-border);
border-radius: var(--vscode-cornerRadius-small);
background: color-mix(in srgb, var(--vscode-foreground) 8%, var(--vscode-agentsPanel-background));
overflow: hidden;
}

Expand All @@ -74,7 +75,7 @@
.agent-global-configuration-settings-row + .agent-global-configuration-settings-text-row,
.agent-global-configuration-settings-text-row + .agent-global-configuration-settings-row,
.agent-global-configuration-settings-text-row + .agent-global-configuration-settings-text-row {
border-top: 1px solid var(--vscode-widget-border, var(--vscode-contrastBorder, transparent));
border-top: var(--vscode-strokeThickness) solid var(--vscode-widget-border, var(--vscode-agentsPanel-border));
}

.agent-global-configuration-settings-labels {
Expand Down
7 changes: 4 additions & 3 deletions src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2488,8 +2488,9 @@ per-word capitalization does not survive translation. */
display: flex;
flex-direction: column;
gap: 0;
border: var(--vscode-strokeThickness) solid var(--vscode-widget-border);
border: var(--vscode-strokeThickness) solid var(--vscode-agentsPanel-border);
border-radius: var(--vscode-cornerRadius-medium);
background: color-mix(in srgb, var(--vscode-foreground) 8%, var(--vscode-agentsPanel-background));
overflow: hidden;
}

Expand Down Expand Up @@ -2541,7 +2542,7 @@ per-word capitalization does not survive translation. */
}

.plugin-list-widget .plugin-home-row:not(:last-child) {
box-shadow: inset 0 calc(-1 * var(--vscode-strokeThickness)) var(--vscode-widget-border);
box-shadow: inset 0 calc(-1 * var(--vscode-strokeThickness)) var(--vscode-widget-border, var(--vscode-agentsPanel-border));
}

.plugin-list-widget .plugin-home-row:hover {
Expand Down Expand Up @@ -2889,7 +2890,7 @@ per-word capitalization does not survive translation. */
padding: var(--vscode-spacing-size120);
border: var(--vscode-strokeThickness) solid var(--vscode-agentsPanel-border);
border-radius: var(--vscode-cornerRadius-large);
background: var(--vscode-editorWidget-background);
background: color-mix(in srgb, var(--vscode-foreground) 8%, var(--vscode-agentsPanel-background));
color: var(--vscode-foreground);
box-sizing: border-box;
cursor: pointer;
Expand Down
12 changes: 6 additions & 6 deletions ...ench/contrib/chat/browser/aiCustomization/media/aiCustomizationWelcomePromptLaunchers.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@
box-sizing: border-box;
padding: var(--vscode-spacing-size160);
margin: var(--vscode-spacing-size200) 0 var(--vscode-spacing-size280);
border: var(--vscode-strokeThickness) solid color-mix(in srgb, var(--vscode-editorWidget-border) 85%, transparent);
border: var(--vscode-strokeThickness) solid var(--vscode-agentsPanel-border);
border-radius: var(--vscode-cornerRadius-large);
background: var(--vscode-editorWidget-background);
background: color-mix(in srgb, var(--vscode-foreground) 8%, var(--vscode-agentsPanel-background));
}

.ai-customization-management-editor .welcome-prompts-section-label {
Expand Down Expand Up @@ -212,9 +212,9 @@
flex-direction: column;
min-width: 0;
padding: var(--vscode-spacing-size120);
border: var(--vscode-strokeThickness) solid var(--vscode-widget-border);
border: var(--vscode-strokeThickness) solid var(--vscode-agentsPanel-border);
border-radius: var(--vscode-cornerRadius-large);
background: var(--vscode-editorWidget-background);
background: color-mix(in srgb, var(--vscode-foreground) 8%, var(--vscode-agentsPanel-background));
color: var(--vscode-foreground);
font: inherit;
text-align: left;
Expand All @@ -233,8 +233,8 @@

.ai-customization-management-editor .welcome-prompts-migration-card {
grid-column: 1 / -1;
background: color-mix(in srgb, var(--vscode-inputValidation-warningBackground) 35%, var(--vscode-sideBar-background));
border-color: color-mix(in srgb, var(--vscode-inputValidation-warningBorder) 70%, var(--vscode-widget-border));
background: color-mix(in srgb, var(--vscode-inputValidation-warningBackground) 35%, var(--vscode-agentsPanel-background));
border-color: color-mix(in srgb, var(--vscode-inputValidation-warningBorder) 70%, var(--vscode-agentsPanel-border));
cursor: pointer;
}

Expand Down
48 changes: 24 additions & 24 deletions test/componentFixtures/blocks-ci-screenshots.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
<!-- auto-generated by CI — do not edit manually -->

#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/73125119f7ad87d8bbae85ed0e685ceafb7e79d1d72d036486990e54160223f1)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/ecbaf7ccf420a40fa66adf92baaaa1a6b5c24575d58db243f33f25d5f3773119)

#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/631f44328275de7742be0cf9f85bcf8e23692104192d653d3f734f61a2b3bdd6)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/c13f82b9dbe63bd2450bb28f48d66704613bfa02a36b47c6a05a3c9b4d0b81ea)

#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/299142bb43919679f11b1320d1297e44cd15f016af0b3d99157976d93721d090)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/6c26540ad074f1bb302f82ce39f5d1cce3478679bd385cc0e5b68c3b7d48c1c7)

#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/7f33c8eadc7d82a9fb30f2e59546b15bf4d6540260c7f0b9247b8d956549acad)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/a90405bc9ec5b34569c77e3d180f79b847afe6daa4668a72d158b9787cfc55bc)

#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/04f8aa6cc6243811fd60682fbd1dd871b7045e6d32b54ffa2d4f4d5331d58df8)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/d51c5ae97416ae8983026c9436150ba766b2837d8794c113ab5891665df74561)

#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/e4677fa2853de20ba9e307155e270fa388465c07c10358a9a1f3ff61a0a1214e)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/e652f2a9309c421bf0a7c805160521ad2837e320fdec9e00393ff981a2eac014)

#### chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/49cd709a8c4d88a3d569d93174245949a9bb187209172e859b1c503e065b2afe)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/34ca750e1747a1e89fbeaab3b755d1372ee503e009f4c2a32a4d7205742b3dce)

#### chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/18a54b51f477fa721d8c9b1ab56ff55e953801bb3b2d14f01eb043c249b73aeb)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/0a8c7e47a3dadf698e121c5bca782d5235ba9cfb205bfa1362307d4fea2e56f6)

#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/60660b23153246506d9710d0239c15292079b357def9bbc8d7f92b8184c058c4)
Expand All @@ -31,46 +31,46 @@
![screenshot](https://hediet-screenshots.azurewebsites.net/images/3a424b83224188683990741c5a50163601605069c5809ae8e60c01dbee749000)

#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/fd25d29993b79ab91112214f250cfad1defa6824963c3af81e680755101984e6)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/818485b76cf89c4cd8951e5819820d764dbcb11505aa0c302cfe757b95981acd)

#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/49c3b0c63a80c07b08a3743b8796d9cf6b02258bb9173b92193cff8b96b39fab)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/9733bdf2e83f6c6442db4d1ced4634a93d8a292d78ae101cf263fea76f64053c)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/6c43ef7d52aa8eb0d576b692fb2d2b0a20dd7677e2280b59c2a80feb2dc34b11)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/52daa14b7b61fd8ea7a28f0db9acaa65dbd403a85078c03cc31c0c135101c236)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/24f0815b7784be0b7a0f10144de52e1746d95874cf19d1b1eb0522595f363ca3)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/94410e4c60912cfa7c8e58096d69c1f3e5d6dde2c5eb4ae17c356d29147c1850)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/1671f24b9ab6711ae5f09998ba83110b8e8776b36b2a79faa72f19b603b5d39f)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/11be24ce9bdb02eaa809b871ba506d469a745e42f8f11250903ddb6084f721db)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/fdf59b4c9ed25069eb8cc0e60b83a7c6cab5fefbb15186413549bc7d084e4155)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/d451310e9fce1333215b6be7d258c5fc131a624a41198251d18b75e37d83d23e)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/22686ac92c2a14563ba7e6d01bb550f78f11eb1c43afeb1ced96529589e82265)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/84c453d09dae5b3b87205364370e55360812a425dda96123659ac15402c5dcb4)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/e97446149b544a13b4549bad9c6b5662ea0b8c0e90d0a7650423ac370d8d69cc)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/669e7d7c8d96c2076c8a576fa3a7e5c5cecf1f95671a675162eefad7a5ff3e11)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/0f3957abfe413adc6948235a3719e3816c894732811ebe7183746dcc9b8c1b4c)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/e2d667dd5052de6eca13f0c07f7b4dfa768a4499cdb10885c6e3bb75b636324f)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/cebf11554d8406530a8096a278fd9e31a1e365e0a81de7ee8b5f363b0c4dc928)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/b1001378286b10e85c5ea0d38a2a39b781a2370e07f686182ac0f7f448f7c0b3)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/0f3957abfe413adc6948235a3719e3816c894732811ebe7183746dcc9b8c1b4c)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/e2d667dd5052de6eca13f0c07f7b4dfa768a4499cdb10885c6e3bb75b636324f)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/cebf11554d8406530a8096a278fd9e31a1e365e0a81de7ee8b5f363b0c4dc928)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/b1001378286b10e85c5ea0d38a2a39b781a2370e07f686182ac0f7f448f7c0b3)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/35d360958fc72a25ba7c2dd68ff3cf994e1f26ed91b6ef1a491fa35690a8e0da)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/71c963b2ea1414b83ed3ad4da0c556197369d23d7f0b63806d0e2bf9f9b04127)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/53ddc34360c336aba42bc527fced457fad6503ea7ed7c5739df13114e3d608b7)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/683eab172739819c9bac2d664ded814f40824de289ca4c3570b6d968bb04070c)

#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/d816d432f1c51513810871127ce8475d572ffd439dc86667d164e713b06042c2)
Expand All @@ -91,10 +91,10 @@
![screenshot](https://hediet-screenshots.azurewebsites.net/images/d9596cabc6fedef4660ac86b2861ff18ebb3a67da723b7014f05fea915059919)

#### chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/bb845f60651850b28b0c3e5ca0b8ed12910a706c00e6bb71c1715bf61a646f2c)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/483f8579ecd4518666859e405e43c08aec24e1a857a05f242517c1916ab21b9a)

#### chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Light
![screenshot](https://hediet-screenshots.azurewebsites.net/images/dd46998ca3d441faee2d504279e5619711d13fb90fc8c6d48d1ea19d5535ca37)
![screenshot](https://hediet-screenshots.azurewebsites.net/images/959217baa8742edd1ec21037a15b15febef35dce360a0fc11cb8f7b1244b977c)

#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Dark
![screenshot](https://hediet-screenshots.azurewebsites.net/images/4cc1460fb1925cee3a2de5e5ae60770984f0490780e294bdcf56fac47c2d1490)
Expand Down
Loading