test: Benchmark Windows node_modules cache formats - #333627
Closed
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
Closed
test: Benchmark Windows node_modules cache formats#333627Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
Conversation
Temporarily compare the current 7-Zip cache with tar.zst on the Windows Electron smoke runner. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 31, 2026 19:24
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Adds a benchmark-only Windows smoke-runner comparison of 7-Zip and native bsdtar/zstd cache formats.
Changes:
- Runs the benchmark on Electron smoke cache hits.
- Measures archive size, creation/extraction duration, and validates file counts.
| File | Description |
|---|---|
.github/workflows/pr-win32-test.yml |
Invokes the benchmark on eligible Windows jobs. |
.github/workflows/node_modules_cache/benchmark.ps1 |
Implements archive creation, extraction, validation, and reporting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Collaborator
Author
|
Closing the benchmark: Windows Server 2022 bsdtar 3.5.2 did not finish creating the tar.zst archive after 2h07m. The run was cancelled, so this format is not viable for the production cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark only — do not merge
Runs a one-off A/B comparison on the Windows Electron smoke runner using the restored production
node_modulescache:The step verifies both formats extract the same number of files and prints archive sizes and durations. This PR will be closed after collecting the result; the production change will be prepared separately.