Fix first plugin skill completion - #333854
Draft
Paul (pwang347) wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused ordering fix is consistent with existing publication logic and has direct regression coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Routes skill completion discovery through serialized customization publishing, ensuring new skills reach session state before completion results.
Changes:
- Exposes an awaitable customization refresh path.
- Uses it for skill completions.
- Adds regression coverage for first-use plugin skills.
| File | Description |
|---|---|
agentSideEffects.ts |
Returns resolved customizations from serialized publication. |
agentService.ts |
Connects completions to the publisher. |
agentHostSkillCompletionProvider.ts |
Supports injected customization resolution. |
agentService.test.ts |
Verifies publication precedes completion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 342383b8-789f-4236-ae1b-a108d68e5a59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionCustomizationsChangedis emitted before the completion response can reach the workbenchFixes #333203
Verification
The regression test demonstrates the ordering bug directly: before the fix the skill completion is returned, but
SessionState.customizationsis stillundefined.Without the fix
With the fix
Related tests
UI verification
Launched Code - OSS Dev from this PR branch with the minimal plugin from #333203 and a fresh Copilot chat. On the first attempt, completion returned
/dummy:print-hello-world; accepting it immediately produced the recognized blue skill token shown below. The DOM assertion independently confirmedced-chat-dynamic-variable-1andced-chat-session-clickable-text-1on the token with colorrgb(133, 182, 255).