sessions: refine single-pane details behavior - #333881
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoSep 1, 2026
Merged
sessions: refine single-pane details behavior#333881Sandeep Somavarapu (sandy081) merged 2 commits into
Sandeep Somavarapu (sandy081) merged 2 commits into
Conversation
Keep the side-pane boundary stable when toggling docked details, align new-session editor closing with existing sessions, and reveal details when Empty Files opens. Also order the details action before maximize and allow workspace-backed draft sessions to open Changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
September 1, 2026 22:01
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
September 1, 2026 22:02
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Details can reopen after unrelated reactive updates despite a subsequent user hide action.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (3)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/layout/browser/singlePane/singlePaneExistingSessionStrategy.ts — This forces Details open on every reactive rerun while Empty Files remains active, not just when… |
|
src/vs/sessions/contrib/layout/browser/singlePane/singlePaneNewSessionStrategy.ts — This forces Details open on any autorun while Empty Files remains active, rather than only when… |
 |
src/vs/sessions/SINGLE_PANE_SCENARIOS.md — This overstates the close behavior: closing the last real file does not close the side pane when a… |
What changed in this PR
Refines single-pane Sessions side-pane sizing, Details visibility, and draft-session behavior.
Changes:
- Stabilizes the Sessions/editor boundary when toggling Details.
- Aligns last-editor closing and Empty Files behavior across session types.
- Enables Changes for workspace-backed drafts and reorders Toggle Details.
| File | Description |
|---|---|
src/vs/sessions/test/browser/workbench.test.ts |
Updates sizing and visibility tests. |
src/vs/sessions/SINGLE_PANE_SCENARIOS.md |
Revises single-pane behavior documentation. |
src/vs/sessions/LAYOUT_CONTROLLER.md |
Documents lifecycle changes. |
src/vs/sessions/contrib/layout/test/browser/singlePaneStrategies.test.ts |
Tests Details and close behavior. |
src/vs/sessions/contrib/layout/test/browser/desktopSessionLayoutController.test.ts |
Updates integration-style layout tests. |
src/vs/sessions/contrib/layout/browser/singlePane/singlePaneNewSessionStrategy.ts |
Changes new-session Details and close handling. |
src/vs/sessions/contrib/layout/browser/singlePane/singlePaneExistingSessionStrategy.ts |
Reveals Files Details and reorders its toggle. |
src/vs/sessions/contrib/editor/test/browser/editor.contribution.test.ts |
Tests draft-session Changes support. |
src/vs/sessions/contrib/editor/browser/addTabActions.ts |
Enables Changes for uncreated sessions. |
src/vs/sessions/browser/singlePaneWorkbench.ts |
Keeps the side-pane boundary stable. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Reveal docked Details only when Empty Files becomes active or visible, rather than on unrelated reactive updates, and clarify the last-editor close contract. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Lively (Yoyokrazy)
approved these changes
Sep 1, 2026
Sandeep Somavarapu (sandy081)
deleted the
sandy081/agents/single-pane-details-panel-updates
branch
September 1, 2026 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run compilenpm run hygiene