Skip to content

Fix list background color issue in customization modals - #334082

Merged
Hawk Ticehurst (hawkticehurst) merged 2 commits into
mainfrom
agents/fix-list-background-color-issue
Sep 2, 2026
Merged

Fix list background color issue in customization modals#334082
Hawk Ticehurst (hawkticehurst) merged 2 commits into
mainfrom
agents/fix-list-background-color-issue

Conversation

@hawkticehurst

@hawkticehurst Hawk Ticehurst (hawkticehurst) commented Sep 2, 2026

Copy link
Copy Markdown
Member

This pull request addresses a regression caused by a previous merge (#333620) that incorrectly applied background colors to list items in customization modal pages. The changes made ensure that only the overview page cards retain their background color, while other lists revert to having no background or matching the parent container's background.

Changes made:

  • Removed background fills from:
    • Customization inventory lists and marketplace cards in aiCustomizationManagement.css.
    • Settings card in agentGlobalConfigurationSettings.css.
  • Overview card backgrounds remain unchanged to preserve the intended design.
ui-diff-20260902-143707

Validation:

  • Stylelint checks passed.
  • All targeted component fixtures rendered without errors.
  • git diff --check passed successfully.

Copilot AI balanced review requested due to automatic review settings September 2, 2026 18:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The CSS-only changes are focused, consistent with the stated design intent, and preserve interaction styling.

Pull request overview

Removes unintended persistent backgrounds from customization modal lists while preserving overview card styling.

Changes:

  • Makes inventory and marketplace cards transparent at rest.
  • Removes the settings-card fill while retaining borders and hover states.
File summaries
File Description
aiCustomizationManagement.css Removes list and marketplace card fills.
agentGlobalConfigurationSettings.css Removes the settings-card fill.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 45f3f80c Current: bbdc8c65

Changed (80)

chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Light
Before After
before after
chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabEmpty/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabEmpty/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersSearch/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersSearch/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabActiveSession/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabActiveSession/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersAuthRequired/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersAuthRequired/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServerActiveSessionDetail/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServerActiveSessionDetail/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsSearch/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsSearch/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsEmptyUser/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsEmptyUser/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/RemoteSkillsTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/RemoteSkillsTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabNarrow/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabNarrow/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/SessionsPluginsTab/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/SessionsPluginsTab/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeEmptyInstalled/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeEmptyInstalled/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabScrolled/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabScrolled/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsItemPreview/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsItemPreview/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsItemRaw/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsItemRaw/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/BuiltinSkillItemPreview/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/BuiltinSkillItemPreview/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/BuiltinSkillItemRaw/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/BuiltinSkillItemRaw/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetail/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetail/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Light
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetailNarrow/Dark
Before After
before after
chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetailNarrow/Light
Before After
before after

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hawkticehurst
Hawk Ticehurst (hawkticehurst) merged commit 365175c into main Sep 2, 2026
60 of 61 checks passed
@hawkticehurst
Hawk Ticehurst (hawkticehurst) deleted the agents/fix-list-background-color-issue branch September 2, 2026 19:54
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants