Polish mock policy server UI - #334122
Merged
joshspicer merged 2 commits intoSep 2, 2026
Merged
Conversation
Improve schema controls, delivery setup, theming, and the editable schema source workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The critical schema-route exposure and unresolved moderate UI and accessibility issues must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (4)
| Severity | Finding |
|---|---|
scripts/mock-policy-server/server.ts — This new unauthenticated control route turns the server into an arbitrary JSON file reader and HTTP… |
|
scripts/mock-policy-server/public/app.ts — This always collapses the Schema section on reload and, because setExpandableSectionState… |
|
scripts/mock-policy-server/public/style.css — Avoid :has() here. Descendant mutations such as checking these radios invalidate ancestor… |
|
scripts/mock-policy-server/public/style.css — Keeping this aria-live node at display: none while empty can prevent assistive technology from… |
What changed in this PR
Polishes the mock policy server UI and adds runtime schema-source editing.
Changes:
- Adds persistent themes and redesigned setup controls.
- Adds
POST /api/schemafor process-local schema loading. - Updates managed-settings and local-testing documentation.
| File | Review |
|---|---|
scripts/mock-policy-server/server.ts |
Critical: The unauthenticated schema route enables arbitrary JSON file reads and HTTP fetching when exposed. Require authentication or restrict access and sources. |
scripts/mock-policy-server/README.md |
Documentation updated; no unresolved comments. |
scripts/mock-policy-server/public/style.css |
Moderate: Replace :has() selection styling and keep the empty live region rendered for assistive technology. |
scripts/mock-policy-server/public/index.html |
Nit: Remove unsupported aria-expanded from native radio controls and corresponding updates. |
scripts/mock-policy-server/public/app.ts |
Moderate: Restore the persisted Schema section expansion state instead of overwriting it with false. |
.github/skills/policy-and-managed-settings/local-testing.md |
Testing guidance updated; no unresolved comments. |
Suppressed comments (1)
scripts/mock-policy-server/public/index.html:63
aria-expandedis not a supported state for the native radio role. The radio's checked state already communicates which delivery mechanism is selected; retainaria-controls, but removearia-expandedhere and the corresponding updates inselectSetupMethodto avoid exposing invalid semantics to assistive technology.
<input id="setup-method-proxy" type="radio" name="setup-method" value="proxy"
aria-expanded="true" aria-controls="proxy-method-content" checked>
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Benjamin Christopher Simmonds (benibenj)
previously approved these changes
Sep 2, 2026
Restrict schema source mutation to loopback URLs, avoid :has state styling, and keep the schema status live region rendered. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
POST /api/schemaValidation
npm run eslint -- scripts/mock-policy-server/public/app.ts scripts/mock-policy-server/server.tsscripts/mock-policy-server/public/app.tsgit diff --check