Skip to content

Classify worked items as session artifacts - #334125

Merged
Benjamin Christopher Simmonds (benibenj) merged 5 commits into
mainfrom
agent/worked-items-are-artifacts
Sep 2, 2026
Merged

Classify worked items as session artifacts#334125
Benjamin Christopher Simmonds (benibenj) merged 5 commits into
mainfrom
agent/worked-items-are-artifacts

Conversation

@benibenj

Copy link
Copy Markdown
Contributor

Summary

  • classify issues and pull requests a session works on as artifacts even when it did not create them
  • align the artifact tool schema, description, system instruction, and validation error
  • add regression coverage for the model guidance

Testing

  • Not run (per request)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The regression test does not verify the classification’s essential subject and creation condition.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 Medium severity

New issues introduced by this change (1)
Severity Finding
Medium severity src/​vs/​platform/​agentHost/​test/​node/​artifactServerTools.test.ts — This checks only the generic fragment “is an artifact even if”, so the regression still passes if…
What changed in this PR

Updates artifact guidance so worked-on issues and pull requests count as session artifacts, even when created elsewhere.

Changes:

  • Aligns tool descriptions, schema guidance, and validation messaging.
  • Adds regression coverage for model-facing guidance.
File Description
artifactServerTools.ts Updates artifact classification guidance.
sessionArtifactCollection.ts Aligns validation error wording.
artifactServerTools.test.ts Tests guidance across model-facing surfaces.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/platform/agentHost/test/node/artifactServerTools.test.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@benibenj
Benjamin Christopher Simmonds (benibenj) merged commit c26d779 into main Sep 2, 2026
40 checks passed
@benibenj
Benjamin Christopher Simmonds (benibenj) deleted the agent/worked-items-are-artifacts branch September 2, 2026 23:38
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants