Classify worked items as session artifacts - #334125
Merged
Benjamin Christopher Simmonds (benibenj) merged 5 commits intoSep 2, 2026
Merged
Classify worked items as session artifacts#334125Benjamin Christopher Simmonds (benibenj) merged 5 commits into
Benjamin Christopher Simmonds (benibenj) merged 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
September 2, 2026 21:43
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 2, 2026 21:44
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The regression test does not verify the classification’s essential subject and creation condition.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
src/vs/platform/agentHost/test/node/artifactServerTools.test.ts — This checks only the generic fragment “is an artifact even if”, so the regression still passes if… |
What changed in this PR
Updates artifact guidance so worked-on issues and pull requests count as session artifacts, even when created elsewhere.
Changes:
- Aligns tool descriptions, schema guidance, and validation messaging.
- Adds regression coverage for model-facing guidance.
| File | Description |
|---|---|
artifactServerTools.ts |
Updates artifact classification guidance. |
sessionArtifactCollection.ts |
Aligns validation error wording. |
artifactServerTools.test.ts |
Tests guidance across model-facing surfaces. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 2, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 2, 2026
c26d779
into
main
40 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
agent/worked-items-are-artifacts
branch
September 2, 2026 23:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing