sessions: move unified workspace picker setting - #334554
Merged
Megan Rogge (meganrogge) merged 6 commits intoSep 4, 2026
Merged
sessions: move unified workspace picker setting#334554Megan Rogge (meganrogge) merged 6 commits into
Megan Rogge (meganrogge) merged 6 commits into
Conversation
Move the No workspace experiment gate into the Sessions chat contribution and rename it to describe the tested UX. Migrate explicit values from the legacy application-scoped setting while preserving explicit values already configured under the new key. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 4, 2026 17:00
View session
Name the experiment gate for the complete unified picker experience, including consolidated remote sources, search, and the No workspace option. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The hidden legacy registration prevents application-scoped values from being loaded and migrated.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/browser/chat.contribution.ts — included: false prevents this legacy key from being loaded by ApplicationConfiguration:… |
 |
src/vs/sessions/contrib/chat/browser/chat.contribution.ts — This description promises that enabling the setting supports workspace-less sessions, but web… |
What changed in this PR
Moves unified workspace picker configuration ownership from shared Chat into Sessions.
Changes:
- Renames and registers the Sessions-owned setting.
- Updates picker, composer, action, and tests.
- Adds legacy-setting migration.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/constants.ts |
Removes the legacy Chat setting constant. |
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Removes shared setting registration. |
src/vs/sessions/contrib/sessions/test/browser/sessionsActions.test.ts |
Updates action tests. |
src/vs/sessions/contrib/sessions/browser/views/sessionsViewActions.ts |
Uses the new setting in Quick Chat. |
src/vs/sessions/contrib/chat/test/browser/sessionWorkspacePicker.test.ts |
Updates picker test configuration. |
src/vs/sessions/contrib/chat/common/constants.ts |
Defines the new setting key. |
src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts |
Uses the Sessions-owned setting. |
src/vs/sessions/contrib/chat/browser/newChatWidget.ts |
Observes the renamed setting. |
src/vs/sessions/contrib/chat/browser/chat.contribution.ts |
Registers and migrates the setting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep the deprecated application-scoped key included so configuration migration can inspect it, and qualify No workspace support in the replacement setting description. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
previously approved these changes
Sep 4, 2026
Keep new and old clients on the same ExP flight by explicitly retaining the existing treatment identifier while the user-facing setting is renamed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 4, 2026 17:16
View session
Allow the renamed setting to derive a matching ExP treatment identifier for a clean restart of the recently launched experiment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The user-setting migration lacks focused coverage for copying and preservation behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/browser/chat.contribution.ts — Add focused coverage for this migration's data-preservation contract: an application-scoped legacy… |
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
|
src/vs/sessions/contrib/chat/browser/chat.contribution.ts — This description promises that enabling the setting supports workspace-less sessions, but web… View resolved comment |
|
src/vs/sessions/contrib/chat/browser/chat.contribution.ts — included: false prevents this legacy key from being loaded by ApplicationConfiguration:… View resolved comment |
Extract the unified workspace picker migration and cover application scope, legacy value removal, value copying, and preservation of an explicit replacement value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 4, 2026 17:49
Martin Aeschlimann (aeschli)
approved these changes
Sep 4, 2026
Megan Rogge (meganrogge)
added
the
feature-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat.agentSessions.consolidatedRemoteWorkspacestosessions.chat.unifiedWorkspacePicker.enabledSetting migration
The deprecated setting remains registered so application-scoped values can be loaded and migrated.
For each explicitly configured legacy value, the migration:
chat.agentSessions.consolidatedRemoteWorkspacessessions.chat.unifiedWorkspacePicker.enabledDefaults and remote experiment assignments are not persisted as user settings, so they are not copied by this migration.
Experiment update
The setting uses the default treatment name derived from its new ID:
config.sessions.chat.unifiedWorkspacePicker.enabledBecause the existing experiment only recently started and has little data, restart it using this new treatment name rather than retaining the legacy identifier indefinitely:
config.chat.agentSessions.consolidatedRemoteWorkspacesconfig.sessions.chat.unifiedWorkspacePicker.enabledfalsefor control andtruefor treatmentDo not delete or rename a shared ExP variant that is used by other experiments; create the replacement flag/progression as required by ExP.
Validation
npm run transpile-clientnpm run hygienenode build/checker/layersChecker.tsnpm run compilereached source compilation but stopped on unrelated generatedmonaco.d.tsdrift already present on the base branchnpm run typecheck-clientand the type-check phase ofnpm run valid-layers-checkare blocked by missing Electron typings in this checkout; no changed-file errors were reported