Fix Agents Window cancellation log noise - #334568
Draft
Paul (pwang347) wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes have regression coverage and no unresolved approval-blocking issues.
Review tier: Balanced
Findings: None
What changed in this PR
Fixes customization bundling races during scope disposal and replacement.
Changes:
- Treats stale bundle work as cancellation.
- Safely drains queued filesystem operations.
- Serializes bundles sharing an authority.
- Adds regression coverage.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/syncedCustomizationBundler.ts |
Adds cancellation-aware disposal, queue draining, and authority sequencing. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/syncedCustomizationBundler.test.ts |
Covers queued disposal and same-authority replacement races. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334441
Summary
Validation
End to end
Object has been disposedbundler errors were written to the Window log.EntryNotFoundtraces, canceled/agents/tasksnetwork errors, or Cloud Sandbox cancellation warnings.Automated
./scripts/test.shover all five affected suites: 101 passingnpm run typecheck-clientnpm run valid-layers-checknpm run hygienenpm run transpile-client