Skip to content

Use standard primary color for agent feedback - #334643

Merged
Benjamin Christopher Simmonds (benibenj) merged 2 commits into
mainfrom
copilot/fix-agent-feedback-primary-button
Sep 7, 2026
Merged

Use standard primary color for agent feedback#334643
Benjamin Christopher Simmonds (benibenj) merged 2 commits into
mainfrom
copilot/fix-agent-feedback-primary-button

Conversation

Copilot AI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use the shared default primary button styles for the agent feedback Accept action
  • add regression coverage for the created-state button colors

Testing

  • npm run transpile-client
  • npm run gulp compile-client (reported 0 TypeScript errors before the local compiler process exited with an unknown code)
  • focused Electron test attempted under Xvfb; blocked by the generated widget module importing its existing raw CSS file

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI requested a balanced review from Copilot and removed request for Copilot September 4, 2026 22:25
@vs-code-engineering

Copy link
Copy Markdown
Contributor

This PR will be automatically cherry-picked to release/1.136 when merged.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: ccfec4b8 Current: 7ccfa544

Changed (6)

sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedPRReviewOnly/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedPRReviewOnly/Light
Before After
before after
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedAllSourcesMixed/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedAllSourcesMixed/Light
Before After
before after
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedPRReview/Dark
Before After
before after
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedPRReview/Light
Before After
before after

4 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

@benibenj Benjamin Christopher Simmonds (benibenj) removed the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Sep 7, 2026
@benibenj

Copy link
Copy Markdown
Contributor

Copilot the badge for example "PR Review" in the agent feedback widget should also be blue instead of purple (same or similar blue as primary button blue)

Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 7, 2026 08:58
Copilot AI removed the request for review from Copilot September 7, 2026 08:58

Copilot AI commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Copilot the badge for example "PR Review" in the agent feedback widget should also be blue instead of purple (same or similar blue as primary button blue)

Updated the feedback type badge to use the primary button blue token in 51119a0.

@benibenj
Benjamin Christopher Simmonds (benibenj) merged commit be31694 into main Sep 7, 2026
33 checks passed
@benibenj
Benjamin Christopher Simmonds (benibenj) deleted the copilot/fix-agent-feedback-primary-button branch September 7, 2026 13:59
@vs-code-engineering vs-code-engineering Bot added this to the 1.138.0 milestone Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants