Enhance cloud sandbox UX for remote connections - #334644
Merged
Osvaldo Ortega (osortega) merged 2 commits intoSep 5, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Osvaldo Ortega (osortega)
September 4, 2026 22:34
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Connection-state and activation races can expose writable chats prematurely or restore handlers after teardown.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (4)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/cloudSandboxAgentHostContribution.ts — Disabling the feature while getEnvironment is in flight can resurrect a read-only content… |
 |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/remoteAgentHostSessionsProvider.ts — readOnlyWhenDisconnected becomes false during the initial connecting state, even though the… |
 |
src/vs/sessions/contrib/providers/remoteAgentHost/browser/cloudSandboxAgentHostContribution.ts — The PR description says cloud sandboxes will use context-specific wording such as “Resuming” and… |
|
src/vs/sessions/contrib/providers/remoteAgentHost/test/browser/cloudSandboxAgentHostContribution.test.ts — This test does not exercise an unreadable environment record: degraded is a successfully returned… |
What changed in this PR
Improves cloud sandbox connection recovery and status presentation in the Agents Window.
Changes:
- Adds provider-specific connection labels and connecting-state UI.
- Opens dormant sandbox sessions from persisted history without automatically waking them.
- Adds transcript-loading and connection-state regression coverage.
| File | Description |
|---|---|
remoteHostUnavailableEmptyState.fixture.ts |
Adds offline and connecting fixtures. |
chatGroupsView.test.ts |
Tests recovery states and labels. |
remoteAgentHostSessionsProvider.test.ts |
Tests reconnect interactivity. |
cloudSandboxAgentHostContribution.test.ts |
Tests sandbox activation behavior. |
remoteAgentHostSessionsProvider.ts |
Adds labels and connection-driven read-only state. |
cloudSandboxReadOnlySessionHandler.ts |
Updates history-provider semantics. |
cloudSandboxAgentHostContribution.ts |
Revises sandbox activation and recovery. |
chatView.ts (contrib) |
Exposes transcript loading state. |
agentHostSessionsProvider.ts |
Defines provider connection labels. |
sessionRemoteConnection.ts |
Updates connection messaging and actions. |
remoteHostUnavailableEmptyState.ts |
Supports optional descriptions. |
remoteHostUnavailableEmptyState.css |
Hides omitted descriptions. |
chatView.ts (browser parts) |
Adds the loading-state contract. |
chatGroupView.ts |
Selects recovery UI after transcript loading. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: 1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. Added (4)
|
Reject stale activation results after cancellation, feature teardown, or provider replacement. Keep initial sandbox connections read-only while preserving input during self-healing reconnects. Add regression coverage for review feedback on #334644, including actual environment lookup failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Osvaldo Ortega (osortega)
marked this pull request as ready for review
September 4, 2026 23:50
Osvaldo Ortega (osortega)
enabled auto-merge (squash)
September 4, 2026 23:50
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
roblourens
approved these changes
Sep 5, 2026
Osvaldo Ortega (osortega)
deleted the
agents/cloud-sandbox-ux-enhancement
branch
September 5, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the connection UX for GitHub-managed cloud sandbox sessions without exposing connection internals.
Validation
npm run typecheck-client: passed.