Skip to content

Make build title prefix optional - #334658

Merged
Bryan Chen (bryanchen-d) merged 1 commit into
mainfrom
copilot/vscode/optional-build-title-prefix
Sep 4, 2026
Merged

Make build title prefix optional#334658
Bryan Chen (bryanchen-d) merged 1 commit into
mainfrom
copilot/vscode/optional-build-title-prefix

Conversation

@bryanchen-d

Copy link
Copy Markdown
Collaborator

Summary

Make VSCODE_BUILD_TITLE_PREFIX optional in Azure DevOps's manual Run Pipeline form without changing existing build names.

Azure runtime parameters cannot be optional, and an empty string is not a usable manual-form default. This change follows the pipeline's existing sentinel pattern:

  • default the parameter to none
  • normalize none to an empty pipeline variable
  • preserve explicit caller prefixes unchanged
  • build the run number from the normalized variable

It also corrects the parameter label to title-style capitalization.

Validation

ADO pipeline 111 previews using this YAML as yamlOverride:

  • no supplied prefix compiled successfully and normalized VSCODE_BUILD_TITLE_PREFIX to ""
  • SDK Integration - compiled successfully and normalized to that exact value
  • both paths retained the existing run-number token pattern

git diff --check, VS Code Problems diagnostics, and staged code review passed.

Authored with Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 4, 2026 23:07
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

  • build/azure-pipelines/product-build.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change follows existing pipeline sentinel patterns and covers both default and explicit-prefix behavior.

Review tier: Balanced
Findings: None

What changed in this PR

Makes the Azure product-build title prefix optional while preserving existing run names.

Changes:

  • Uses none as the manual-form sentinel.
  • Normalizes it to an empty variable.
  • Corrects label capitalization.
File Description
build/​azure-pipelines/​product-build.yml Adds optional title-prefix normalization and uses it in run names.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bryanchen-d
Bryan Chen (bryanchen-d) merged commit 60912b0 into main Sep 4, 2026
41 checks passed
@bryanchen-d
Bryan Chen (bryanchen-d) deleted the copilot/vscode/optional-build-title-prefix branch September 4, 2026 23:46
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants