Skip to content

[cherry-pick] Build with @github/copilot canary version - #334680

Closed
vs-code-engineering[bot] wants to merge 1 commit into
mainfrom
cherry-pick/334649
Closed

[cherry-pick] Build with @github/copilot canary version#334680
vs-code-engineering[bot] wants to merge 1 commit into
mainfrom
cherry-pick/334649

Conversation

@vs-code-engineering

Copy link
Copy Markdown
Contributor

Cherry-pick of #334649 from release/1.137.

Summary

  • keep OSS builds on the public @github/copilot and @github/copilot-sdk versions
  • keep product builds on the same SDK as OSS
  • check in 1.0.84-canary.67.g6496fad.unsigned as the default product @github/copilot runtime version
  • extend the existing authenticated Azure override to support runtime-only changes
  • accept the runtime's policyHelper managed-settings diagnostics source

Implementation

The existing VSCODE_CLI_CANARY_VERSION parameter remains the product-build override mechanism, but its checked-in default is now the desired runtime canary. VSCODE_SDK_CANARY_VERSION stays none, so product builds retain the SDK from the OSS manifest. The shared pre-cache step now runs when either override is present and refreshes only the dependency that changed.

Validation

  • cd build && npm run typecheck
  • npm run typecheck-client
  • npm run hygiene
  • authenticated CLI-only override exercised in root and remote manifests using the prior published runtime canary
  • read-only subagent review found no significant issues

The requested 1.0.84-canary.67.g6496fad.unsigned package is not yet visible on the private feed, so an Azure product build with that exact runtime cannot succeed until it is published.

Ported to release/1.137; main counterpart is #334648.

(Written by Copilot)

Copilot AI balanced review requested due to automatic review settings September 5, 2026 01:46
@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label Sep 5, 2026
@vs-code-engineering

Copy link
Copy Markdown
Contributor Author

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

  • build/azure-pipelines/common/apply-sdk-canary-override.ts
  • build/azure-pipelines/common/apply-sdk-canary.yml
  • build/azure-pipelines/product-build-ado-ci.yml
  • build/azure-pipelines/product-build.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The default runtime version is unpublished, causing default product and ADO CI builds to fail.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates product builds to use a canary Copilot runtime while retaining the OSS SDK version.

Changes:

  • Enables runtime-only Copilot dependency overrides in Azure pipelines.
  • Sets the product runtime default to a specific canary.
  • Accepts policyHelper as a managed-settings diagnostics source.
File summaries
File Description
build/azure-pipelines/product-build.yml Sets the product runtime canary default.
build/azure-pipelines/product-build-ado-ci.yml Mirrors the runtime default for ADO CI.
build/azure-pipelines/common/apply-sdk-canary.yml Runs overrides for SDK or runtime changes.
build/azure-pipelines/common/apply-sdk-canary-override.ts Supports independent runtime overrides.
src/vs/platform/agentHost/common/agent.ts Extends the diagnostics source union.
src/vs/platform/agentHost/test/node/e2e/suites/managementExtensionsSuite.ts Accepts the new diagnostics source in E2E validation.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@roblourens roblourens closed this Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants