[cherry-pick] Build with @github/copilot canary version - #334680
Closed
vs-code-engineering[bot] wants to merge 1 commit into
Closed
[cherry-pick] Build with @github/copilot canary version#334680vs-code-engineering[bot] wants to merge 1 commit into
vs-code-engineering[bot] wants to merge 1 commit into
Conversation
Contributor
Author
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The default runtime version is unpublished, causing default product and ADO CI builds to fail.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates product builds to use a canary Copilot runtime while retaining the OSS SDK version.
Changes:
- Enables runtime-only Copilot dependency overrides in Azure pipelines.
- Sets the product runtime default to a specific canary.
- Accepts
policyHelperas a managed-settings diagnostics source.
File summaries
| File | Description |
|---|---|
build/azure-pipelines/product-build.yml |
Sets the product runtime canary default. |
build/azure-pipelines/product-build-ado-ci.yml |
Mirrors the runtime default for ADO CI. |
build/azure-pipelines/common/apply-sdk-canary.yml |
Runs overrides for SDK or runtime changes. |
build/azure-pipelines/common/apply-sdk-canary-override.ts |
Supports independent runtime overrides. |
src/vs/platform/agentHost/common/agent.ts |
Extends the diagnostics source union. |
src/vs/platform/agentHost/test/node/e2e/suites/managementExtensionsSuite.ts |
Accepts the new diagnostics source in E2E validation. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #334649 from
release/1.137.Summary
@github/copilotand@github/copilot-sdkversions1.0.84-canary.67.g6496fad.unsignedas the default product@github/copilotruntime versionpolicyHelpermanaged-settings diagnostics sourceImplementation
The existing
VSCODE_CLI_CANARY_VERSIONparameter remains the product-build override mechanism, but its checked-in default is now the desired runtime canary.VSCODE_SDK_CANARY_VERSIONstaysnone, so product builds retain the SDK from the OSS manifest. The shared pre-cache step now runs when either override is present and refreshes only the dependency that changed.Validation
cd build && npm run typechecknpm run typecheck-clientnpm run hygieneThe requested
1.0.84-canary.67.g6496fad.unsignedpackage is not yet visible on the private feed, so an Azure product build with that exact runtime cannot succeed until it is published.Ported to
release/1.137; main counterpart is #334648.(Written by Copilot)