fix: remove duplicate UNIFIED_WORKSPACE_PICKER_SETTING import (build fix for vscode-engineering#3803) - #334686
Draft
VS Code PR Bot (vscodebot-pr) wants to merge 1 commit into
Conversation
…fix for vscode-engineering#3803) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
VS Code PR Bot (vscodebot-pr)
September 5, 2026 02:53
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The mechanical removals resolve the reported build errors while preserving all symbol usages.
Pull request overview
Removes duplicate imports that caused TS2300 compilation failures without changing runtime behavior.
Changes:
- Retains one valid
UNIFIED_WORKSPACE_PICKER_SETTINGimport in each affected file. - Removes the redundant duplicate imports.
File summaries
| File | Description |
|---|---|
copilotChatSessionsProvider.ts |
Removes duplicate production import. |
copilotChatSessionsProvider.test.ts |
Removes duplicate test import. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build failure
Every Compile task on
mainfails withtsgoTS2300 duplicate-identifier errors, cascading to all downstream Test/Publish/Verify jobs across the Linux, macOS, Windows and Quality stages:Root cause
copilotChatSessionsProvider.tsand its test each importedUNIFIED_WORKSPACE_PICKER_SETTINGfrom../../../chat/common/constants.jstwice — once mid-import-block and once appended at the end of the import list. TypeScript rejects a symbol imported twice into the same module scope (TS2300), so compilation aborts before any task can run.How the fix works
Removes the redundant second
import { UNIFIED_WORKSPACE_PICKER_SETTING }line in each of the two files, keeping a single import. The symbol is still available at all its use sites, so behavior is unchanged and typechecking passes.Rollback evaluation
Recommendation: Do not roll back. Culprit: commit
291338d45a319004f26078f6b505745d62202f62/ PR #334674. A one-line duplicate-import deletion in each file lands faster and more safely than reverting a large model-picker PR touching many files. Owners to consult:@lramos15Validation
Verified by source inspection that only one import of the symbol remains in each file (
grepcount = 1). Fulltsgo/compile validation could not be run in this environment; the change is a mechanical duplicate-import removal that directly resolves the TS2300 errors.Risk
Minimal — removes redundant imports only; no logic, telemetry, or runtime behavior changes.
Recommended reviewer
Recommended owner:
@lramos15Fixes microsoft/vscode-engineering#3803