eslint: fix bracket notation in remote tooling - #334770
Open
Dmitriy Vasyura (dmitrivMS) wants to merge 7 commits into
Open
eslint: fix bracket notation in remote tooling#334770Dmitriy Vasyura (dmitrivMS) wants to merge 7 commits into
Dmitriy Vasyura (dmitrivMS) wants to merge 7 commits into
Conversation
Enable code-no-bracket-notation-for-identifiers for JavaScript and TypeScript files while grandfathering the 509 files with existing violations in a CODEOWNERS-gated allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Organize the existing baseline by feature area so cleanup can be tracked and assigned without changing the excluded file set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add RuleTester coverage for valid accesses, diagnostics, and autofix edge cases. Preserve escaped string-literal property names by checking their raw source before reporting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use dot notation across remote, tunnel, networking, and authentication code and remove the 11 cleaned files from the allowlist. Replace private-member test access with explicit session persistence and command-level test seams. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 6, 2026 21:16
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes have no unresolved approval-blocking issues.
Review tier: Balanced
Findings: None
What changed in this PR
Updates remote tooling and authentication code to comply with the bracket-notation ESLint rule while preserving test coverage through public seams.
Changes:
- Replaces identifier-style bracket access with dot notation.
- Adds testable seams for persisted GitHub sessions and tunnel startup.
- Removes cleaned files from the ESLint allowlist.
| File | Description |
|---|---|
src/vs/workbench/contrib/remoteTunnel/test/electron-browser/remoteTunnel.contribution.test.ts |
Exercises startup through the registered command. |
src/vs/workbench/contrib/remote/browser/remoteStartEntry.ts |
Updates tunnel-tip property access. |
src/vs/platform/webContentExtractor/test/electron-main/webPageLoader.test.ts |
Updates header assertions. |
src/vs/platform/webContentExtractor/electron-main/webPageLoader.ts |
Updates request-header access. |
src/vs/platform/tunnel/test/node/tunnelProxy.test.ts |
Updates tunnel header assertions. |
src/vs/platform/tunnel/node/tunnelProxy.ts |
Updates header and regex-group access. |
src/vs/platform/request/node/requestService.ts |
Updates redirect-header access. |
src/vs/platform/remote/node/wsl.ts |
Updates SystemRoot access. |
src/vs/platform/github/common/githubTransport.ts |
Updates authorization-header access. |
extensions/microsoft-authentication/src/common/experimentation.ts |
Updates package-version access. |
extensions/github-authentication/src/test/github.test.ts |
Tests session persistence without private access. |
extensions/github-authentication/src/github.ts |
Extracts persisted-session reading into a testable function. |
.eslint-allowed-bracket-notation-files |
Removes 11 remediated paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dmitriy Vasyura (dmitrivMS)
marked this pull request as ready for review
September 6, 2026 21:51
Dmitriy Vasyura (dmitrivMS)
requested a review
from Alexandru Dima (alexdima)
as a code owner
September 6, 2026 21:51
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 6, 2026 21:51
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: TylerLeonhardtMatched files:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eslint-allowed-bracket-notation-filesThis PR is intentionally stacked on #334756, which enables
local/code-no-bracket-notation-for-identifiers. Its base should be changed tomainafter #334756 merges.Validation
--max-warnings=0across all changed JavaScript and TypeScript filesnpm run typecheck-clientnpm run transpile-clientgit diff --check