eslint: fix bracket notation in language extensions - #334771
Merged
Dmitriy Vasyura (dmitrivMS) merged 11 commits intoSep 12, 2026
Merged
eslint: fix bracket notation in language extensions#334771Dmitriy Vasyura (dmitrivMS) merged 11 commits into
Dmitriy Vasyura (dmitrivMS) merged 11 commits into
Conversation
Enable code-no-bracket-notation-for-identifiers for JavaScript and TypeScript files while grandfathering the 509 files with existing violations in a CODEOWNERS-gated allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Organize the existing baseline by feature area so cleanup can be tracked and assigned without changing the excluded file set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add RuleTester coverage for valid accesses, diagnostics, and autofix edge cases. Preserve escaped string-literal property names by checking their raw source before reporting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace identifier-safe bracket notation across language feature extensions and remove the completed group from the temporary allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
marked this pull request as ready for review
September 6, 2026 21:31
Dmitriy Vasyura (dmitrivMS)
requested a review
from Alexandru Dima (alexdima)
as a code owner
September 6, 2026 21:31
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 6, 2026 21:31
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 6, 2026 21:31
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The conversions are behavior-preserving, and the affected files no longer contain identifier-safe bracket notation.
Review tier: Balanced
Findings: None
What changed in this PR
Replaces identifier-safe bracket notation with equivalent dot notation across language-feature extensions and removes the completed ESLint allowlist group.
Changes:
- Updates property access across 22 extension files.
- Removes those files from the bracket-notation allowlist.
- Preserves existing runtime behavior.
| File | Description |
|---|---|
.eslint-allowed-bracket-notation-files |
Removes the completed 22-file exclusion group. |
extensions/css-language-features/client/src/node/cssClientMain.ts |
Updates environment-variable access. |
extensions/css-language-features/server/src/cssServer.ts |
Updates static service lookup. |
extensions/css-language-features/server/src/node/cssServerNodeMain.ts |
Updates environment-variable access. |
extensions/emmet/src/abbreviationActions.ts |
Updates static argument, configuration, and option access. |
extensions/emmet/src/defaultCompletionProvider.ts |
Updates Emmet configuration access. |
extensions/emmet/src/splitJoinTag.ts |
Updates syntax-profile access. |
extensions/emmet/src/util.ts |
Updates Emmet configuration access. |
extensions/html-language-features/client/src/autoInsertion.ts |
Updates auto-insertion state access. |
extensions/html-language-features/client/src/node/htmlClientMain.ts |
Updates environment-variable access. |
extensions/html-language-features/server/src/modes/languageModes.ts |
Updates static language-mode access. |
extensions/html-language-features/server/src/node/htmlServerNodeMain.ts |
Updates environment-variable access. |
extensions/json-language-features/client/src/node/jsonClientMain.ts |
Updates environment and header access. |
extensions/json-language-features/server/src/node/jsonServerNodeMain.ts |
Updates environment-variable access. |
extensions/markdown-language-features/src/extension.ts |
Updates environment-variable access. |
extensions/markdown-language-features/src/languageFeatures/copyFiles/copyFiles.ts |
Updates named regex-group access. |
extensions/markdown-language-features/src/languageFeatures/copyFiles/snippets.ts |
Updates named regex-group access. |
extensions/markdown-language-features/src/markdownEngine.ts |
Updates renderer-rule access. |
extensions/merge-conflict/src/mergeDecorator.ts |
Updates decoration access. |
extensions/typescript-language-features/src/logging/telemetry.ts |
Updates telemetry property access. |
extensions/typescript-language-features/src/tsServer/serverProcess.electron.ts |
Updates process-environment construction. |
extensions/typescript-language-features/src/typescriptServiceClient.ts |
Updates telemetry property access. |
extensions/typescript-language-features/src/utils/platform.ts |
Updates global property access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep process.env accesses out of this cleanup now that the lint rule exempts them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
added
vscode-build
Alexandru Dima (alexdima)
approved these changes
Sep 12, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
agents/fix-bracket-notation-language-extensions
branch
September 12, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.eslint-allowed-bracket-notation-files