eslint: fix bracket notation in test infrastructure - #334773
Merged
Dmitriy Vasyura (dmitrivMS) merged 8 commits intoSep 7, 2026
Merged
eslint: fix bracket notation in test infrastructure#334773Dmitriy Vasyura (dmitrivMS) merged 8 commits into
Dmitriy Vasyura (dmitrivMS) merged 8 commits into
Conversation
Enable code-no-bracket-notation-for-identifiers for JavaScript and TypeScript files while grandfathering the 509 files with existing violations in a CODEOWNERS-gated allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Organize the existing baseline by feature area so cleanup can be tracked and assigned without changing the excluded file set. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add RuleTester coverage for valid accesses, diagnostics, and autofix edge cases. Preserve escaped string-literal property names by checking their raw source before reporting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace identifier-safe bracket notation across test infrastructure and remove the completed group from the temporary allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 6, 2026 20:50
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are exhaustive, mechanical property-access substitutions with no identified semantic differences.
Review tier: Balanced
Findings: None
What changed in this PR
Replaces identifier-safe bracket notation with equivalent dot notation throughout test infrastructure and removes the completed ESLint allowlist group.
Changes:
- Updates property access across 18 test files without behavioral changes.
- Removes those files from the bracket-notation allowlist.
| File | Description |
|---|---|
.eslint-allowed-bracket-notation-files |
Removes the completed test infrastructure group. |
test/unit/electron/renderer.js |
Updates util.inspect property access. |
test/unit/electron/preload.js |
Updates environment-variable access. |
test/unit/electron/index.js |
Updates development-mode access. |
test/smoke/test/index.js |
Updates CLI option access. |
test/smoke/src/areas/preferences/preferences.test.ts |
Updates element style attribute access. |
test/smoke/src/areas/agentsWindow/agentsWindow.test.ts |
Updates environment-variable access. |
test/sanity/src/main.ts |
Updates detection option access. |
test/sanity/src/context.ts |
Updates environment-variable access. |
test/monaco/esm-check/esm-check.js |
Updates Playwright browser access. |
test/componentFixtures/playwright/tests/utils.ts |
Updates component explorer port access. |
test/componentFixtures/playwright/tests/chatResizeObserver.spec.ts |
Updates fixture dataset access. |
test/automation/src/search.ts |
Updates title attribute access. |
test/automation/src/scm.ts |
Updates action title access. |
test/automation/src/electron.ts |
Updates test environment assignments. |
src/vs/workbench/test/browser/componentFixtures/resizeObserver.fixture.ts |
Updates fixture dataset access. |
src/vs/workbench/test/browser/componentFixtures/multiDiffEditorScroll.fixture.ts |
Updates serialized-state property access. |
src/vs/workbench/test/browser/componentFixtures/chat/chatWidget.fixture.ts |
Updates fixture dataset access. |
src/vs/platform/instantiation/test/common/instantiationServiceMock.ts |
Updates mock metadata access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dmitriy Vasyura (dmitrivMS)
marked this pull request as ready for review
September 6, 2026 20:54
Dmitriy Vasyura (dmitrivMS)
requested a review
from Alexandru Dima (alexdima)
as a code owner
September 6, 2026 20:54
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 6, 2026 20:54
Alexandru Dima (alexdima)
approved these changes
Sep 7, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
agents/fix-bracket-notation-test-infrastructure
branch
September 7, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eslint-allowed-bracket-notation-filesThis is a mechanical cleanup for
local/code-no-bracket-notation-for-identifierswith no intended behavior changes.Validation
npm run typecheck-clientnpm run transpile-clientnode --checkStacking
Stacked on #334756 and intended to merge after that PR.