chat: Reveal current Agent Host session in Agents Window - #334934
Merged
Alexandru Dima (alexdima) merged 2 commits intoSep 7, 2026
Merged
chat: Reveal current Agent Host session in Agents Window#334934Alexandru Dima (alexdima) merged 2 commits into
Alexandru Dima (alexdima) merged 2 commits into
Conversation
When enabled by the experimental setting, make the title bar Open in Agents action reveal the current persisted local Agent Host session. Preserve the new-session fallback for all other cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Alexandru Dima (alexdima)
September 7, 2026 15:13
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused, gated change preserves fallback behavior and has targeted test coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Adds experiment-gated routing so the title-bar Open in Agents action reveals the current persisted local Agent Host session while retaining existing fallback behavior.
Changes:
- Registers a disabled-by-default experimental setting.
- Routes eligible sessions to the Agents Window.
- Tests enabled, disabled, untitled, remote, regular, and absent-session cases.
| File | Description |
|---|---|
constants.ts |
Defines the configuration key. |
chat.shared.contribution.ts |
Registers the experimental setting. |
agentSessionsActions.ts |
Implements session-aware routing. |
agentSessionsActions.test.ts |
Covers routing and fallback behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alexandru Dima (alexdima)
marked this pull request as ready for review
September 7, 2026 16:59
Start resolving an existing-session handoff as soon as initial UI restore begins instead of waiting for the deferred Eventually lifecycle phase. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
approved these changes
Sep 7, 2026
Alexandru Dima (alexdima)
deleted the
alexd/open-in-agents-reveal-session
branch
September 7, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eventuallylifecycle waitchat.experimental.openInAgentsWindow.revealCurrentSessionsetting, defaulting tofalseTesting
npm run transpile-clientnpm run eslint -- src/vs/workbench/contrib/chat/common/constants.ts src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts src/vs/workbench/contrib/chat/electron-browser/agentSessions/agentSessionsActions.ts src/vs/workbench/contrib/chat/test/electron-browser/agentSessionsActions.test.tsnpm run eslint -- src/vs/sessions/contrib/chat/electron-browser/chat.contribution.tsscripts/test.sh --runGlob "**/workbench/contrib/chat/test/electron-browser/agentSessionsActions.test.js"npm run typecheck-clientis currently blocked by existing Agent Host SDK declaration mismatches in untouched files.