Fix Claude customization migration targets - #334942
Open
Martin Aeschlimann (aeschli) wants to merge 3 commits into
Open
Fix Claude customization migration targets#334942Martin Aeschlimann (aeschli) wants to merge 3 commits into
Martin Aeschlimann (aeschli) wants to merge 3 commits into
Conversation
Fixes #334938 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Martin Aeschlimann (aeschli)
September 7, 2026 15:56
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Equal workspace and user scope buckets must be deduplicated to prevent ambiguous duplicate targets.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/platform/agentHost/node/claude/customizations/claudeSessionCustomizationDiscovery.ts — When a workspace root equals userHome (the existing “preserves single-root workspace attribution”… |
What changed in this PR
Publishes writable Claude customization directories, including empty migration targets.
Changes:
- Emits agent, skill, and rule directories across workspace and user scopes.
- Adds coverage for empty and populated targets.
| File | Description |
|---|---|
src/vs/platform/agentHost/test/node/customizations/claudeSessionCustomizationDiscovery.test.ts |
Updates discovery expectations and coverage. |
src/vs/platform/agentHost/node/claude/customizations/claudeSessionCustomizationDiscovery.ts |
Publishes migration targets, but can duplicate targets when a workspace root equals the user home. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+154
to
+158
| result.push( | ||
| makeDirectory(bucket.base, 'agents', CustomizationType.Agent, bucket.agents), | ||
| makeDirectory(bucket.base, 'skills', CustomizationType.Skill, bucket.skills), | ||
| makeDirectory(bucket.base, 'rules', CustomizationType.Rule, bucket.rules), | ||
| ); |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 7, 2026
Martin Aeschlimann (aeschli)
enabled auto-merge (squash)
September 8, 2026 09:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishes writable Claude
agents,skills, andrulesdirectory customizations for every workspace and user scope, including empty directories. This allows the migration service to retain legacy customization candidates that have a valid Claude destination but no existing Claude customization of that type.Adds focused discovery coverage for empty workspace and user migration targets while preserving coverage of populated directories.
Fixes #334938
Testing
./scripts/test.sh --run src/vs/platform/agentHost/test/node/customizations/claudeSessionCustomizationDiscovery.test.ts