Skip to content

Add unread treatment for Automations new badge - #334946

Merged
Ulugbek Abdullaev (ulugbekna) merged 3 commits into
mainfrom
ulugbekna/agents/automation-unread-badge-feature
Sep 7, 2026
Merged

Add unread treatment for Automations new badge#334946
Ulugbek Abdullaev (ulugbekna) merged 3 commits into
mainfrom
ulugbekna/agents/automation-unread-badge-feature

Conversation

@ulugbekna

Copy link
Copy Markdown
Contributor

Summary

Adds an unread treatment to the Automations first-use badge experiment on top of #334898.

  • reuse the standard filled unread indicator in the Automations leading icon slot
  • hide the trailing NEW capsule for this treatment
  • preserve input-needed, running, and actual unread-run status precedence
  • keep the existing first-use accessibility and dismissal behavior

Verification

  • npm run compile — completed with 0 errors
  • focused Automations badge and Sessions list tests — 102 passing
  • targeted ESLint for all six changed files
  • Component Explorer renders in Dark, Light, and Dark High Contrast with no errors
  • Code OSS Agents window: reset the badge with the unread treatment, verified codicon-circle-filled, hidden trailing badge, new feature accessibility text, and dismissal after opening Automations

Reuse the standard Automations unread status indicator as an alternative first-use treatment while preserving operational status precedence and accessibility semantics.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 7, 2026 16:15
@ulugbekna Ulugbek Abdullaev (ulugbekna) added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Sep 7, 2026
@vs-code-engineering

Copy link
Copy Markdown
Contributor

This PR will be automatically cherry-picked to release/1.137 when merged.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The unread visual fixture must be added to the blocking screenshot gate.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 Medium severity

New issues introduced by this change (1)
Severity Finding
Medium severity src/​vs/​workbench/​test/​browser/​componentFixtures/​sessions/​sessionsList.fixture.ts — This new visual treatment is not opted into the blocking screenshot gate, unlike the adjacent…
What changed in this PR

Adds an unread-style treatment for the Automations first-use badge while preserving status precedence, accessibility, and dismissal behavior.

Changes:

  • Adds unread as a supported badge style.
  • Uses the standard unread indicator instead of the trailing NEW capsule.
  • Extends unit and visual fixture coverage.
File Description
src/​vs/​workbench/​test/​browser/​componentFixtures/​sessions/​sessionsList.fixture.ts Adds the unread visual fixture; moderate issue: it is not opted into the blocking screenshot gate.
src/​vs/​sessions/​contrib/​sessions/​test/​browser/​sessionsList.test.ts Tests rendering, precedence, dismissal, and accessibility.
src/​vs/​sessions/​contrib/​sessions/​test/​browser/​automationsNewBadge.test.ts Covers style resolution and preview behavior.
src/​vs/​sessions/​contrib/​sessions/​browser/​views/​sessionsList.ts Renders the unread indicator with status precedence.
src/​vs/​sessions/​contrib/​sessions/​browser/​sessions.contribution.ts Registers the new style value.
src/​vs/​sessions/​contrib/​sessions/​browser/​automationsNewBadge.ts Extends badge-style typing and normalization.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/workbench/test/browser/componentFixtures/sessions/sessionsList.fixture.ts Outdated
Opt the unread Automations badge fixture into the blocking screenshot gate so theme and rendering regressions are detected.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 89eff76f Current: 8fd45586

6 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (3)

sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Dark

current

sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Light

current

sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/DarkHighContrast

current

Record the Linux CI hashes for the unread Automations badge in dark, high-contrast, and light themes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ulugbekna
Ulugbek Abdullaev (ulugbekna) merged commit 1b921e3 into main Sep 7, 2026
33 checks passed
@ulugbekna
Ulugbek Abdullaev (ulugbekna) deleted the ulugbekna/agents/automation-unread-badge-feature branch September 7, 2026 18:30
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 7, 2026
@ulugbekna Ulugbek Abdullaev (ulugbekna) added ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Sep 7, 2026
Ulugbek Abdullaev (ulugbekna) added a commit that referenced this pull request Sep 7, 2026
Add unread treatment for Automations new badge (#334946)

* automations: feat: add unread new badge treatment

Reuse the standard Automations unread status indicator as an alternative first-use treatment while preserving operational status precedence and accessibility semantics.



* automations: test: gate unread badge screenshots

Opt the unread Automations badge fixture into the blocking screenshot gate so theme and rendering regressions are detected.



* automations: test: accept unread badge screenshots

Record the Linux CI hashes for the unread Automations badge in dark, high-contrast, and light themes.



---------


(cherry picked from commit 1b921e3)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants