Fix compact search editor control spacing

[Lee Murray (mrleemurray)]

Summary

Fixes #334867.

• Keep the Agents window search header at its normal height and vertical padding when editor tabs use compact density. The search controls remain full height and should not touch the results separator.
• Add real SearchEditor fixtures for default and compact density in dark, light, and dark high-contrast themes.
• Leave default-density spacing unchanged.

Validation

• All six fixtures render and dispose without errors.
• All six fixtures have stable screenshots; compact and default screenshots match in each theme.
• Targeted ESLint, stylelint, editor diagnostics, and git diff --check pass.
• Measured compact header: 32px high, with 26px input controls and 2px vertical padding. The input-to-separator gap increases from 0.75px to 2.75px.

Before

Original report with window.density.editorTabHeight set to compact:

How to test

1. In the Agents window, set window.density.editorTabHeight to compact and open the Search editor.
2. Verify there is visible spacing above and below the search controls and before the results separator.
3. Switch to default tab density and verify search-control spacing is unchanged.
4. In Component Explorer, review sessions/searchEditor/{Default,Compact}/{Dark,Light,DarkHighContrast}.

After

Fresh capture of the real SearchEditor compact-density fixture from this branch. The controls retain their full height with visible vertical padding before the separator.

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

• src/vs/sessions/browser/parts/media/editorPart.css

[Copilot]

🟢 Approval recommended

The focused CSS correction is consistent with the intended layout and is covered by representative visual fixtures.

Pull request overview

Restores consistent Search Editor spacing in the Agents window when compact tab density is enabled.

Changes:

• Removes the compact-density override that collapsed header padding and height.
• Adds themed Search Editor fixtures for default and compact densities.

File summaries

File	Description
src/vs/sessions/browser/parts/media/editorPart.css	Preserves standard Search Editor header spacing in compact mode.
src/vs/sessions/contrib/search/test/browser/searchEditor.fixture.ts	Adds visual fixtures across density and theme variants.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Screenshot Changes

Base: 4df1a8df Current: 2cab0723

4 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (6)

sessions/searchEditor/Default/Dark

sessions/searchEditor/Default/Light

sessions/searchEditor/Default/DarkHighContrast

sessions/searchEditor/Compact/Dark

sessions/searchEditor/Compact/Light

sessions/searchEditor/Compact/DarkHighContrast