sessions: Show pinned state in session toolbar - #334957
Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit intoSep 7, 2026
Merged
Conversation
Keep the pin toggle in the overflow menu while also showing its toggled action in the navigation group for pinned session views. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
September 7, 2026 17:47
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 7, 2026 17:47
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation and tests have no unresolved issues.
Review tier: Balanced
Findings: None
What changed in this PR
Shows pinned state in the session toolbar while retaining the overflow pin/unpin action.
Changes:
- Adds a pinned-only navigation action.
- Expands tests for menu placement, ordering, and predicates.
| File | Description |
|---|---|
src/vs/sessions/contrib/sessions/browser/sessionsActions.ts |
Adds conditional navigation placement for pinned sessions. |
src/vs/sessions/contrib/sessions/test/browser/sessionsActions.test.ts |
Verifies toolbar placements, ordering, and predicates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Henning Dieterichs (hediet)
approved these changes
Sep 7, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 7, 2026
33b6777
into
main
34 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/agents/session-view-pin-toggle-feature
branch
September 7, 2026 19:28
|
Pada Sel, 8 Sep 2026 02.32, Benjamin Christopher Simmonds <
***@***.***> menulis:
… Merged #334957 <#334957> into
main.
—
Reply to this email directly, view it on GitHub
<#334957?email_source=notifications&email_token=CM7ETLLX3ABNHCVH26WGNXD5N4EMJA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMBXGEYDOMJVGI3DFJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-30710715262>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CM7ETLILPHKH43W22AU773L5N4EMJAVCNFSNUABEKJSXA33TNF2G64TZHM2DCOBYGE4TAMB3JFZXG5LFHM2TGNZXGY3TENRYHCQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/CM7ETLON544DGKQAQFMK3TT5N4EMJA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMBXGEYDOMJVGI3DFJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/CM7ETLIKRBJUFXTEUIOLZKD5N4EMJA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMBXGEYDOMJVGI3DFJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation