[cherry-pick] Add PatchBased02UnifiedEagerness prompt strategy - #334978
Merged
Ulugbek Abdullaev (ulugbekna) merged 1 commit intoSep 8, 2026
Merged
Conversation
Add the standalone PatchBased02UnifiedEagerness strategy as a clone of PatchBased02Unified with the aggressionHighLow eagerness prompt. Apply strategy configuration to default-model retries and cover prompt construction, response format, and configuration propagation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Ulugbek Abdullaev (ulugbekna)
September 7, 2026 21:34
View session
Ulugbek Abdullaev (ulugbekna)
enabled auto-merge (squash)
September 7, 2026 21:34
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a straightforward additive strategy variant with consistent wiring across config, prompt building, and provider selection, and it includes targeted unit test coverage for the new behavior.
Review tier: Lite
Findings: None
What changed in this PR
This PR cherry-picks the addition of a new Copilot inline-edits prompting strategy, PatchBased02UnifiedEagerness, implemented as a PatchBased02Unified variant with eagernessPrompt: "aggressionHighLow" baked into the per-strategy configuration.
Changes:
- Add
PromptingStrategy.PatchBased02UnifiedEagernessand wire it into eagerness recognition and response-format selection. - Factor out the shared PatchBased02 unified strategy config and introduce a new strategy config entry that sets
eagernessPrompt: "aggressionHighLow". - Extend provider/prompt-crafting logic and add targeted unit tests covering config application, eagerness detection, and prompt composition ordering.
| File | Description |
|---|---|
| extensions/copilot/src/platform/inlineEdits/common/dataTypes/xtabPromptOptions.ts | Adds the new prompting strategy and per-strategy config override for eagerness, and updates strategy-based helpers. |
| extensions/copilot/src/platform/inlineEdits/test/common/xtabPromptOptions.spec.ts | Adds unit tests validating config parity vs unified and eagerness recognition after config application. |
| extensions/copilot/src/extension/xtab/node/xtabProvider.ts | Includes the new strategy in system prompt selection. |
| extensions/copilot/src/extension/xtab/test/node/xtabProvider.spec.ts | Adds coverage for strategy inclusion and eagerness prompt propagation in model config overrides. |
| extensions/copilot/src/extension/xtab/common/promptCrafting.ts | Treats the new strategy as patch-based for cursor-location prompt building and postscript eagerness tagging. |
| extensions/copilot/src/extension/xtab/test/common/promptCrafting.spec.ts | Adds a regression test ensuring eagerness tags are placed before the postscript for the new strategy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Benjamin Christopher Simmonds (benibenj)
approved these changes
Sep 7, 2026
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 8, 2026
Ulugbek Abdullaev (ulugbekna)
deleted the
ulugbekna/cherry-pick-333302-release-1.137
branch
September 8, 2026 00:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #333302 from
main.Adds the standalone
PatchBased02UnifiedEagernessprompting strategy as a clone ofPatchBased02UnifiedwitheagernessPrompt: "aggressionHighLow". The prerequisite from #333606 is already present onrelease/1.137via #334830.Validation: