Skip to content

Move customization list scrollbar to pane edge - #335355

Merged
Paul (pwang347) merged 10 commits into
microsoft:mainfrom
pwang347:pwang/customizations-scrollbar-edge
Sep 11, 2026
Merged

Move customization list scrollbar to pane edge#335355
Paul (pwang347) merged 10 commits into
microsoft:mainfrom
pwang347:pwang/customizations-scrollbar-edge

Conversation

@pwang347

@pwang347 Paul (pwang347) commented Sep 9, 2026

Copy link
Copy Markdown
Member

Summary

  • move the customizations list, migration page, and Tools section scrollbars to the outer pane edge
  • make each panel own vertical spacing while its header, controls, and content own their horizontal inset
  • give virtualized pages dedicated native scroll containers around their content roots
  • preserve the existing centered maximum width without negative margins or synthetic width expansion
  • fix the clipped Extension Tools section so every tool set remains reachable
  • strengthen narrow fixtures with independently scrollable outer and nested lists

Fixes #335508

Verification

  • npm run stylelint -- src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css
  • npm run eslint -- src/vs/workbench/contrib/chat/browser/aiCustomization/{aiCustomizationManagementEditor,toolsListWidget}.ts
  • npm run eslint -- src/vs/workbench/test/browser/componentFixtures/sessions/aiCustomizationManagementEditor.fixture.ts
  • 69 focused customization editor/list/Tools unit tests
  • all migration fixtures, plus Agents standard/narrow, Skills, Tools standard/narrow/light/empty/browse, and MCP regression fixtures
  • customization and migration nested-scroll assertions: Workspace items, outer sections, and User items scroll independently
  • Extension Tools assertion: outer sections reach Extension Tools, its nested list reaches exact end, and Tool Set 8 is visible

After

Customization list — outer and nested scrollbars

customizations-scrollbar-after-final.mp4

Migrations dashboard and workspace review scrollbars

merged-migration-scrollbars-final.mp4

Extension Tools — #335508

extension-tools-overflow-final.mp4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 9, 2026 21:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The scoped CSS correctly preserves content alignment while relocating the scrollbar without introducing accessibility or layout issues.

Review tier: Balanced
Findings: None

What changed in this PR

Moves the customization list scrollbar to the pane edge while preserving centered, inset content.

Changes:

  • Expands the list widget to the pane edges.
  • Retains the existing 840px content limit and inset alignment.
File Description
aiCustomizationManagement.css Adjusts list and scroll-container sizing.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Paul (pwang347) and others added 7 commits September 10, 2026 11:06
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes microsoft#335508

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Paul (pwang347) marked this pull request as ready for review September 10, 2026 23:00
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Paul (pwang347) enabled auto-merge (squash) September 10, 2026 23:24
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pwang347
Paul (pwang347) merged commit 34e15bd into microsoft:main Sep 11, 2026
33 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.138.0 milestone Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AI Customizations: Extension Tools list is clipped and hides tools

3 participants