Fix fast model toggle not being persisted - #335510
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Refreshing with an empty sizing tab can collapse the active list to zero height.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/platform/actionWidget/browser/tabbedActionListWidget.ts — Normalize an empty sizing result the same way as the initial measurement below.… |
What changed in this PR
Fixes fast model preference persistence in the tabbed model picker while preserving pin state and popup sizing.
Changes:
- Remembers and restores preferred speed variants.
- Collapses model pairs consistently across sections and search.
- Recomputes popup sizing after list changes.
| File | Description |
|---|---|
modelPickerTelemetry.test.ts |
Tests speed-selection and pin telemetry. |
modelPickerTabs.test.ts |
Tests variant collapsing, pins, and availability. |
modelPickerVariants.ts |
Resolves remembered speed variants. |
modelPickerTabs.ts |
Builds sections from collapsed variants. |
modelPickerTabbedWidget.ts |
Persists speed choices and unified pin state. |
tabbedActionListWidget.test.ts |
Tests refreshed popup sizing. |
tabbedActionListWidget.ts |
Remeasures sizing content on refresh. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Henning Dieterichs (hediet)
previously approved these changes
Sep 10, 2026
Logan Ramos (lramos15)
disabled auto-merge
September 10, 2026 16:55
Sandeep Somavarapu (sandy081)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.