chat: register Agents Window settings in editor - #335539
Merged
Megan Rogge (meganrogge) merged 4 commits intoSep 10, 2026
Merged
Conversation
Move the shared settings schemas into the workbench chat contribution so settings.json recognizes them in both the editor and Agents Window. Add regression coverage for the shared registration.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 10, 2026 19:31
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The registration relocation breaks the focused GitHub contribution test unless it explicitly imports the shared contribution.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/github/browser/github.contribution.ts — Update the focused test after relocating registration |
What changed in this PR
Registers Agents Window settings in the shared workbench contribution so they are recognized by the standard settings editor.
Changes:
- Centralizes three setting identifiers and configuration metadata.
- Reuses shared identifiers from Sessions contributions.
- Adds registration regression coverage.
| File | Description |
|---|---|
chatConfiguration.test.ts |
Tests shared registration. |
constants.ts (workbench) |
Defines shared setting identifiers and tag. |
chat.shared.contribution.ts |
Registers the three settings. |
sessionLifecycleSettings.ts |
Reuses shared cleanup identifiers. |
github.contribution.ts |
Removes duplicate cleanup registrations. |
constants.ts (sessions chat) |
Reuses the unified picker identifier. |
chat.contribution.ts |
Removes duplicate picker registration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
previously approved these changes
Sep 10, 2026
Load the Agents Window setting schemas through a narrow contribution so focused and aggregate unit test runs do not re-register unrelated chat commands. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
previously approved these changes
Sep 10, 2026
Capture registration state before configuration registry tests clear the shared global registry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Justin Chen (justschen)
approved these changes
Sep 10, 2026
Megan Rogge (meganrogge)
deleted the
agents/unknown-settings-debugging-1-138
branch
September 10, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the settings added by #334341 and #334554 appearing as unknown in the normal
settings.jsoneditor.Validation
git diff --check/Users/meganrogge/Library/Caches/ms-playwright