sessions: revert Agents Window taskbar shortcut and icons - #335597
Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit intoSep 11, 2026
Merged
Conversation
This reverts commit 716e76d. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
September 10, 2026 23:52
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 10, 2026 23:52
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes consistently reverse the targeted feature without leaving dangling references.
Review tier: Balanced
Findings: None
What changed in this PR
Reverts #335333, restoring standard Windows and Switch Window icon behavior while returning Agents workspaces to jump-list recents.
Changes:
- Removes the dedicated Agents Window jump-list task and Windows icon.
- Removes window icon metadata plumbing.
- Restores default workspace icons and recent-workspace handling.
| File | Description |
|---|---|
build/gulpfile.vscode.ts |
Stops packaging the Sessions icon. |
resources/win32/sessions.ico |
Removes the dedicated Windows icon. |
src/vs/platform/native/electron-main/nativeHostMainService.ts |
Stops exposing native window icons. |
src/vs/platform/window/common/window.ts |
Removes icon metadata from opened windows. |
src/vs/platform/window/electron-main/window.ts |
Removes icon metadata from ICodeWindow. |
src/vs/platform/windows/electron-main/windowImpl.ts |
Restores default native window icons. |
src/vs/platform/windows/test/electron-main/windowsFinder.test.ts |
Updates the test window implementation. |
src/vs/platform/workspaces/electron-main/workspacesHistoryMainService.ts |
Restores Agents workspaces to jump-list recents. |
src/vs/workbench/electron-browser/actions/windowActions.ts |
Restores resource-derived Switch Window icons. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Don Jayamanne (DonJayamanne)
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #335333
Validation
npm run compile.\scripts\test.bat --run src\vs\platform\windows\test\electron-main\windowsFinder.test.ts(5 passing)npm run hygiene(blocked by the existing Windows path resolution issue:C:\C:\repos\vscode\remote\package.json)