ci: Reuse idle integration test workers - #335897
Closed
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Closed
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Dmitriy Vasyura (dmitrivMS) wants to merge 3 commits into
Conversation
Queue remaining node.js integration tests in freed Agent Host E2E worker slots instead of waiting for every E2E suite. Opt in the existing PR Electron jobs while preserving the four-worker limit, suite selection, reports, and failure handling. Refs #335333 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 11, 2026 21:13
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Combined mode must prevent live Codex tests from running concurrently with replay E2E workers.
Review tier: Lite (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Lite.
What changed in this PR
Adds opt-in scheduling to reuse idle Agent Host E2E workers for remaining Node.js integration tests.
Changes:
- Updates cross-platform entrypoints and three PR workflows.
- Adds scheduler, entrypoint, and documentation coverage.
- Review note: live Codex tests may run concurrently in combined mode and require handling before approval.
| File | Description |
|---|---|
src/vs/platform/agentHost/test/node/e2e/README.md |
Documents the CI opt-in. |
scripts/test-integration.sh |
Adds POSIX opt-in routing. |
scripts/test-integration.bat |
Adds Windows opt-in routing. |
scripts/test-agent-host-e2e.ts |
Schedules E2E and remaining Node.js test groups. |
build/lib/test/integrationTestRunner.test.ts |
Tests entrypoint behavior. |
build/lib/test/agentHostE2ERunner.test.ts |
Tests scheduler behavior. |
.github/workflows/pr-win32-test.yml |
Enables Windows scheduling. |
.github/workflows/pr-linux-test.yml |
Enables Linux scheduling. |
.github/workflows/pr-darwin-test.yml |
Enables macOS scheduling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
blocks-ci screenshots changedReplace the contents of Updated blocks-ci-screenshots.md<!-- auto-generated by CI — do not edit manually -->
#### baseUI/KeyboardFocusedToggle/Dark
#### baseUI/KeyboardFocusedToggle/DarkHighContrast
#### baseUI/KeyboardFocusedToggle/Light
#### baseUI/KeyboardFocusedToggle/LightHighContrast
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentHostPromptMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/CodexSkillMissingDescriptionHover/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/CodexSkillMissingDescriptionHover/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/ConfiguredLocationsMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/ConfiguredLocationsMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/HooksEmptyWorkspace/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServerDetailNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/MigrationDashboard/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/MigrationDashboard/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHome/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogHomeNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginCatalogSearch/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginDetail/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/SessionsCodexSkillMissingDescriptionHover/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/SessionsCodexSkillMissingDescriptionHover/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTab/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTab/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTabNarrow/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/ToolsTabNarrow/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/UserDataMigration/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/UserDataMigration/Light
#### chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Dark
#### chat/aiCustomizations/aiCustomizationManagementEditor/WelcomePage/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllAccessoriesFacing/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllRuntimeStates/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/AllRuntimeStates/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CoveredAntennaeComparison/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CoveredAntennaeComparison/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CriticalPoses/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/CriticalPoses/Light
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/LiveEyeLayering/Dark
#### chat/chatPetAccessoryRig/chatPetAccessoryRig/LiveEyeLayering/Light
#### chat/chatQuestionCarousel/MarkdownLinks/Dark
#### chat/chatQuestionCarousel/MarkdownLinks/DarkHighContrast
#### chat/chatQuestionCarousel/MarkdownLinks/Light
#### chat/chatQuestionCarousel/MarkdownLinks/LightHighContrast
#### chat/input/chatInput/CompactWithProviderIcon/Dark
#### chat/input/chatInput/CompactWithProviderIcon/Light
#### chat/input/chatInput/CopilotHarnessCompactPickers/Dark
#### chat/input/chatInput/CopilotHarnessCompactPickers/Light
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Dark
#### chat/petAchievements/standaloneModal/chatPetAchievementsEditor/MixedSelected/Light
#### comments/commentTree/CommentTreeMetadataZoomed/Dark
#### comments/commentTree/CommentTreeMetadataZoomed/DarkHighContrast
#### comments/commentTree/CommentTreeMetadataZoomed/Light
#### comments/commentTree/CommentTreeMetadataZoomed/LightHighContrast
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthClassification/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthClassification/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthCode/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthCode/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthFont/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthFont/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthProportionalFont/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthProportionalFont/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthSelection/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthSelection/Light
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthTwoCells/Dark
#### editor/fullwidthCharacterWidth/FullwidthCharacterWidthTwoCells/Light
#### editor/injectedTextDecorations/ColorDecorators/Dark
#### editor/injectedTextDecorations/ColorDecorators/Light
#### editor/injectedTextDecorations/InlayHints/Dark
#### editor/injectedTextDecorations/InlayHints/Light
#### editor/injectedTextDecorations/InlineProgress/Dark
#### editor/injectedTextDecorations/InlineProgress/Light
#### editor/injectedTextDecorations/SelectedColorDecorator/Dark
#### editor/injectedTextDecorations/SelectedColorDecorator/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
#### editor/wordWrapIndicator/WordWrapIndicator/Dark
#### editor/wordWrapIndicator/WordWrapIndicator/DarkHighContrast
#### editor/wordWrapIndicator/WordWrapIndicator/Light
#### editor/wordWrapIndicator/WordWrapIndicatorDisabled/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorDisabled/Light
#### editor/wordWrapIndicator/WordWrapIndicatorFixedColumnBeyondViewport/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorFixedColumnBeyondViewport/Light
#### editor/wordWrapIndicator/WordWrapIndicatorVariableLineHeight/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorVariableLineHeight/Light
#### editor/wordWrapIndicator/WordWrapIndicatorViewportWrapping/Dark
#### editor/wordWrapIndicator/WordWrapIndicatorViewportWrapping/Light
#### sessions/accountMenu/petAchievementBadges/chatPetAchievementBadges/AllBadges/Dark
#### sessions/accountMenu/petAchievementBadges/chatPetAchievementBadges/AllBadges/Light
#### sessions/chat/input/chatInput/ResponsiveModelResizeCycleMinimal/Dark
#### sessions/chat/input/chatInput/ResponsiveModelResizeCycleMinimal/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionChatBackground/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Light
#### sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Dark
#### sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Light
#### sessions/chat/view/chatView/AssistantResponseBackground/Dark
#### sessions/chat/view/chatView/AssistantResponseBackground/Light
#### sessions/chat/view/chatView/AssistantResponsePlain/Dark
#### sessions/chat/view/chatView/AssistantResponsePlain/Light
#### sessions/chat/view/chatView/CheckpointControlsBackground/Dark
#### sessions/chat/view/chatView/CheckpointControlsBackground/Light
#### sessions/chat/view/chatView/RequestAttachmentBackground/Dark
#### sessions/chat/view/chatView/RequestAttachmentBackground/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Light
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Dark
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/DarkHighContrast
#### sessions/sessionsList/SessionsList_AutomationsNewBadge/Light
#### sessions/sessionsList/SessionsList_LightweightNewButton/Dark
#### sessions/sessionsList/SessionsList_LightweightNewButton/DarkHighContrast
#### sessions/sessionsList/SessionsList_LightweightNewButton/Light
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Dark
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/DarkHighContrast
#### sessions/sessionsList/SessionsList_LightweightNewButtonWithKeybindingBackground/Light
#### sessions/sessionsList/SessionsList_NarrowHoverToolbar/Dark
#### sessions/sessionsList/SessionsList_NarrowHoverToolbar/Light
#### sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Dark
#### sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Light
#### sessions/sessionsList/SessionsList_PeerChatInProgress/Dark
#### sessions/sessionsList/SessionsList_PeerChatInProgress/Light
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Dark
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/DarkHighContrast
#### sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Light
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/Dark
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/DarkHighContrast
#### workbench/activityBarMenu/CompactActivityBarMenu_CompactDensity/Light
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/Dark
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/DarkHighContrast
#### workbench/activityBarMenu/CompactActivityBarMenu_DefaultDensity/Light
Patch--- test/componentFixtures/blocks-ci-screenshots.md 2026-09-12 00:11:56.400842185 +0000
+++ /tmp/blocks-ci-updated.md 2026-09-12 00:28:48.920608593 +0000
@@ -115,7 +115,7 @@
#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Dark
-
+
#### chat/aiCustomizations/aiCustomizationManagementEditor/PromptMigration/Light
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The GitHub Actions investigation for #335333 found that Windows / Electron took 14m44s-17m55s across three runs. The remaining node integration tests waited for all four E2E workers, despite a worker becoming idle earlier.
Two Windows samples suggest approximately 163-168 seconds of scheduling headroom by using that idle slot without raising peak worker concurrency. This is a model, not a measured speedup; overall PR completion also depends on the smoke jobs.
Validation
Draft for real GitHub Actions integration validation and before/after timing comparison. Full Electron integration tests and end-to-end performance measurements have not been run locally.