Merged
Conversation
You can use the |
Collaborator
Author
|
Thanks Ed, I'll give that a try. |
Collaborator
Author
|
Weirdly this causes an entirely different warning. No idea why this is coming from the build script. |
Collaborator
Author
|
So I was able to keep this for most of the crates and further refine code gen to elide code that depended on excluded features, which is great. 🎉 I still have to allow the warning for the |
Collaborator
Author
|
Looks like the error is coming from the |
tbu-
added a commit
to tbu-/rust
that referenced
this pull request
May 7, 2024
This allows to find solutions to the false positives that were found in the ecosystem before turning it to `warn` by default again. Most projects hit by this seem to just disable the warning, which indicates that it isn't working as expected. CC rust-lang#124800 CC rust-lang#124804 CC rust-lang#124821 CC hyperium/hyper#3660 CC microsoft/windows-rs#3022 CC rust-bitcoin/rust-bitcoin#2748 CC tokio-rs/tokio#6538
mati865
pushed a commit
to mati865/windows-rs
that referenced
this pull request
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much like tokio-rs/tokio#6538 I need to silence the new warnings introduced by rust-lang/cargo#13571 about unexpected
cfgcondition names because the alternative is to use a build script which is undesirable and impractical as that introduces a warning about a build script syntax that isn't compatible with the MSRV.I was able to keep this for most of the crates and further refine code gen to elide code that depended on excluded features.