Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: OliverBetz.ExifTool version 13.10 #200906

Merged
merged 3 commits into from
Dec 27, 2024
Merged

New version: OliverBetz.ExifTool version 13.10 #200906

merged 3 commits into from
Dec 27, 2024
+83 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Dec 21, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

Image
Image

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Dec 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 21, 2024
Dragon1573
Dragon1573 commented Dec 21, 2024
View reviewed changes
Copy link
Contributor Author

@Dragon1573 Dragon1573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Komac generated an incorrect manifest, installer file should be "re-hash".

manifests/o/OliverBetz/ExifTool/13.10/OliverBetz.ExifTool.installer.yaml Outdated Show resolved Hide resolved
manifests/o/OliverBetz/ExifTool/13.10/OliverBetz.ExifTool.installer.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 21, 2024
@Dragon1573
Apply suggestions from code review
404289c 
- Correction of `InstallerSha256` of `x86` arch installer
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 21, 2024
@wingetbot
Copy link
Collaborator

=== manifests\o\OliverBetz\ExifTool\13.10 ===
Missing Properties value based on version 12.97:
AppsAndFeaturesEntries

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 26, 2024
@Dragon1573 @mdanish-kh
Apply suggestions from code review
4e6cb7d 
- Move elevation requirements to installer entrance level
- User scope does not need elevation

Co-authored-by: Muhammad Danish <[email protected]>
auto-merge was automatically disabled December 27, 2024 02:43

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed Changes-Requested Changes Requested Manifest-Metadata-Consistency New-Manifest labels Dec 27, 2024
@wingetbot
Copy link
Collaborator

=== manifests\o\OliverBetz\ExifTool\13.10 ===
Missing Properties value based on version 12.97:
ElevationRequirement
AppsAndFeaturesEntries

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 9d535c0 into microsoft:master Dec 27, 2024
2 checks passed
@Dragon1573 Dragon1573 deleted the issues/200346 branch December 27, 2024 07:31
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@DuckDuckStudio DuckDuckStudio mentioned this pull request Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdanish-kh mdanish-kh mdanish-kh approved these changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Metadata-Consistency Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: OliverBetz.ExifTool 12.97
4 participants
@Dragon1573 @wingetbot @mdanish-kh @stephengillie