add support for AIPService #751
Closed
+1,569
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor assessment script by updating region markers and improving condition checks.
removed extra lines
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Data - 35009 - Co-Authoring Enabled for Encrypted Documents
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Azure Information Protection (AIP) service by introducing a new assessment test (35011) to evaluate AIP super user configuration and integrating AipService module connection functionality into the Connect-ZtAssessment cmdlet.
Key Changes:
- New test to check if AIP super user feature is enabled and has designated super users configured
- Added AipService to the list of supported services in Connect-ZtAssessment
- Implemented module import with Windows PowerShell compatibility for PowerShell Core environments
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/powershell/tests/Test-Assessment.35011.ps1 | Implements new assessment test for AIP super user feature configuration with error handling and detailed reporting |
| src/powershell/tests/Test-Assessment.35011.md | Provides documentation and remediation guidance for the AIP super user feature test |
| src/powershell/public/Connect-ZtAssessment.ps1 | Adds AipService to ValidateSet, module import order, import logic with PowerShell Core compatibility, and connection logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: aahmed-spec <[email protected]>
Extract hardcoded AD ports to constant for maintainability
Inconsistent indentation detected. Lines 249-256 use tabs while the rest of the file uses spaces. PowerShell style guidelines typically recommend using spaces consistently throughout the file for better readability across different editors. Co-authored-by: Copilot <[email protected]>
Inconsistent indentation detected. Line 346 uses tabs while the rest of the file uses spaces. PowerShell style guidelines typically recommend using spaces consistently throughout the file for better readability across different editors. Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
"url" capitalized as "URL" Co-authored-by: Copilot <[email protected]>
corrected grammar
…Workloads Data-35030-DLP-Policies-Cloud-Workloads
Network-25395: Entra Private Access Application segments are defined to enforce least-privilege access
…5411 Integrate Find-ZtProfilesLinkedToPolicy 25411
Data-35025: Internal RMS Licensing Enabled
…olicy Add Find-ZtProfilesLinkedToPolicy function to evaluate linked filtering profiles
…s://github.com/microsoft/zerotrustassessment into Data-35011-Super-User-Membership-Configuration
Collaborator
Author
|
created new pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Test Results - https://github.com/microsoft/ztspecs/issues/65